Basic attribute support for Windows systems. about crossterm HOT 8 CLOSED

Thanks for the issue, you are right windows terminals are not supporting attributes. Not sure what you mean with 'partial attributes'. The link you sent is about the ANSI escape codes which could be used for Windows 10 systems. Currently, crossterm already uses ANSI escape codes instead of WinApi for Windows 10 systems.

Could you elaborate more on what you mean with 'partial support' or 'partial attributes'?

from crossterm.

As in, unless I'm understanding this incorrectly, this shows that it supports bold (among others):
https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences#text-formatting

from crossterm.

Ah, yea now I see. I did never saw those options in the document, must have overlooked them. This is actually really cool and will be implemented of course. Thanks for creating this issue and letting me know.

Just for issue record:

The following attributes are needed to be implemented.

Currently, this is already working for UNIX terminal and so it is just a matter of removing some #[cfg(unix)] attributes from the following methods. So that windows systems are also able to call those style methods.

https://github.com/TimonPost/crossterm/blob/master/src/modules/style/styledobject.rs#L84
https://github.com/TimonPost/crossterm/blob/master/src/modules/style/styledobject.rs#L101
https://github.com/TimonPost/crossterm/blob/master/src/modules/style/styledobject.rs#L120

from crossterm.

Hm, I might be wrong.
While it says it supports it, the terminal would disagree...

from crossterm.

Ok, nevermind.
I missed the foreach loops when I was removing the cfg(unix)s.
It works now, but my god, it's barely visible...
It's basically just more... white....

from crossterm.

That's strange lol. However, how is Underline etc. doing?

from crossterm.

This is the final result with the PR I just made (Excluding the double "Bold Text". I had a duplicate line...).

from crossterm.

Awesome, work!

from crossterm.