Tests about crow HOT 4 CLOSED

Update: Websockets suffer the same problem as request streaming, It sends data directly over the TCP socket (or SSL stream), which as far as I know isn't very testable, so aside from the setup code, there isn't much to test without some sort of fake read/write methods or some debug tools in ASIO (which I don't believe there are)

Edit: a simple client to test the received data might be useful, though I do not believe code coverage and unit tests are important enough to warrant dropping the main issues to write a client, maybe when the code is in a stable state, or if someone kindly opens a PR with such a client implemented

from crow.

Ok so after some research, data coming through a socket by creating our own socket and connecting it to an ioservice, similar to how it's done in tests like simple_url_params, IDK why I was too blind to see these tests, regardless. I'll be changing the tests for sendfile and request streaming to test using a socket, this should solve the issues above + a new issue i discovered where the tests don't even send the response (hence the lack of coverage for streaming)

from crow.

It might be the case that Mustache Tests are not being considered in coverage. This could be due to the fact that the file being run is a python script that generates temporary files and runs the actual C++ test. Although I'm not 100% sure of it. only 85%

Update: I confirmed GCOV files are only being created for unittest

Update2: Adding a simple line to include mustachetest in coverage increased mustache.h coverage from 33.45% to 91.96% and finally got us out of the damn red zone

from crow.

SSL tests have been merged into revamped_setup

from crow.