compilation error for BOOST version == 1.64 about crow HOT 7 CLOSED

The problem here is that between boost 1.6 and 1.7 they seem to have changed completion_condition() function.

We are developing and testing with boost 1.7, ipkn/crow uses boost 1.5

from crow.

Is this a problem to update to the newest boost @choice17 ? ;)

from crow.

Is this a problem to update to the newest boost @choice17 ? ;)

Not really, however, it would be nice to have it compatible to lower version.

from crow.

I'm not sure if that's a good idea. It requires additional work and it looks like a quirk in only one version of boost.

from crow.

we could potentially add a macro to check the boost version, and add a warning at the start of the application that "support for boost versions below 1.7 is deprecated and will be removed in a future release" just as a transition, this check would need to be added to the parts that @mrozigor changed while adding support to 1.7, and the socket shutdown parts added by me.

@mrozigor what do you think?

from crow.

If this isn't really necessary then I think that this is waste of time.

from crow.

closing this for now, @choice17 feel free to reopen if this issue is really important

from crow.