Comments (9)
This has been fixed already in #55.
Unfortunately the fix is not included in any formal release.
@cristian-stoica , I think cryptodev-linux-1.12 tag should be applied, to make this fix (and also the recent fix in #57) visible to outside world.
from cryptodev-linux.
@horiag, I agree. If there are no pending patches I'll apply the 1.12 tag next week.
from cryptodev-linux.
Seems like this issue can be closed?
from cryptodev-linux.
fixed some time ago
from cryptodev-linux.
I have experienced the same error while compiling cryptodev-linux-1.13 for mainline kernel v6.6 , Do we need to fix it for each version? what is the workaround?
from cryptodev-linux.
I have experienced the same error while compiling cryptodev-linux-1.13 for mainline kernel v6.6 , Do we need to fix it for each version? what is the workaround?
Yes, unfortunately. This is because cryptodev is out-of-kernel driver. For in-kernel drivers someone already took the trouble to update them to new APIs.
from cryptodev-linux.
Can confirm regression too:
linux 6.6.x
musl
gcc 13
binutils2.41
make[1]: Entering directory '/buildroot/output/build/linux-6.6.3'
CC [M] /buildroot/output/build/cryptodev-linux-1.13/./ioctl.o
CC [M] /buildroot/output/build/cryptodev-linux-1.13/./main.o
CC [M] /buildroot/output/build/cryptodev-linux-1.13/./cryptlib.o
CC [M] /buildroot/output/build/cryptodev-linux-1.13/./authenc.o
CC [M] /buildroot/output/build/cryptodev-linux-1.13/./zc.o
../cryptodev-linux-1.13/zc.c: In function '__get_userbuf':
../cryptodev-linux-1.13/zc.c:84:15: error: too many arguments to function 'get_user_pages_remote'
84 | ret = get_user_pages_remote(mm,
| ^~~~~~~~~~~~~~~~~~~~~
In file included from ../cryptodev-linux-1.13/zc.c:28:
./include/linux/mm.h:2419:6: note: declared here
2419 | long get_user_pages_remote(struct mm_struct *mm,
| ^~~~~~~~~~~~~~~~~~~~~
make[3]: *** [scripts/Makefile.build:243: /buildroot/output/build/cryptodev-linux-1.13/./zc.o] Error 1
make[3]: *** Waiting for unfinished jobs....
../cryptodev-linux-1.13/ioctl.c:1249:18: error: 'struct ctl_table' has no member named 'child'
1249 | .child = verbosity_ctl_dir,
| ^~~~~
../cryptodev-linux-1.13/ioctl.c:1249:35: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
1249 | .child = verbosity_ctl_dir,
| ^~~~~~~~~~~~~~~~~
../cryptodev-linux-1.13/ioctl.c:1249:35: note: (near initialization for 'verbosity_ctl_root[0]')
../cryptodev-linux-1.13/ioctl.c:1249:35: error: incompatible types when initializing type 'enum <anonymous>' using type 'struct ctl_table *'
../cryptodev-linux-1.13/ioctl.c: In function 'init_cryptodev':
../cryptodev-linux-1.13/ioctl.c:1270:35: error: implicit declaration of function 'register_sysctl_table'; did you mean 'unregister_sysctl_table'? [-Werror=implicit-function-declaration]
1270 | verbosity_sysctl_header = register_sysctl_table(verbosity_ctl_root);
| ^~~~~~~~~~~~~~~~~~~~~
| unregister_sysctl_table
../cryptodev-linux-1.13/ioctl.c:1270:33: warning: assignment to 'struct ctl_table_header *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1270 | verbosity_sysctl_header = register_sysctl_table(verbosity_ctl_root);
| ^
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:243: /buildroot/output/build/cryptodev-linux-1.13/./ioctl.o] Error 1
make[2]: *** [/buildroot/output/build/linux-6.6.3/Makefile:1913: /buildroot/output/build/cryptodev-linux-1.13/.] Error 2
make[1]: *** [Makefile:234: __sub-make] Error 2
make[1]: Leaving directory '/buildroot/output/build/linux-6.6.3'
make: *** [package/pkg-generic.mk:284: /buildroot/output/build/cryptodev-linux-1.13/.stamp_built] Error 2
from cryptodev-linux.
I have built it with some tweaks in zc.c and ioctl.c . Should I send a patch or PR?
from cryptodev-linux.
@Vishwasrao1 build issues related to changes in get_user_pages_remote have been fixed several months ago. Please use the current master branch instead of 1.13
from cryptodev-linux.
Related Issues (20)
- SSH with openssl "mux digest failed" HOT 5
- Openembedded out of tree patches HOT 5
- OpenSSL patch website cannot be opened, where to find the patch please? HOT 3
- encrypt-then-mac in aead is more secure
- kle
- openssl_wrapper.c needs to be updated for openssl 3.0.0 HOT 3
- "possible circular locking dependency" warning HOT 3
- pgcrypto to use cryptodev HOT 2
- [OpenBMC] Kernel panic while running "openssl engine" within cryptodev-linux kernel module inserted HOT 1
- What's the supported kernel version list? HOT 2
- Unable to fetch URL from any source HOT 3
- No file to patch. Skipping patch. HOT 3
- module install HOT 1
- Cryptodev module fails to load with Unknown symbol errors HOT 1
- Cipher supports in cryptodev-linux HOT 2
- AES-GCM tag issue HOT 5
- performance issue HOT 4
- the async mode is not truely async
- Phase 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cryptodev-linux.