Comments (6)
faustinoaq
commented on May 28, 2024
Edit: see comments below.
It depends of theme, this extension already has parameter support. <- Not true
Currently I'm using https://marketplace.visualstudio.com/items?itemName=faustinoaq.theme-olivine-comments to get good crystal highlighting. <- Not solution
…On Sat, Jul 29, 2017 at 12:36 AM, Hanyuan Li ***@***.***> wrote:
Maybe support highlighting of this:
[1, 2, 3].map { |a| a + 1 }
The a in |a| should be highlighted as a parameter.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/faustinoaq/vscode-crystal-lang/issues/8>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AC7Nx6Fee4hIpr1BgwZmLnRY0_hzIEQgks5sSsTcgaJpZM4OnQ5X>
.
from vscode-crystal-lang.
faustinoaq
commented on May 28, 2024
^^^^ <~ Not solution
Notice the blue a in |a|
Edit: see comments below
from vscode-crystal-lang.
hanyuone
commented on May 28, 2024
Shouldn't it be highlighted in the same way as a parameter, though? Why is there a need for two highlighting methods?
I'm using VS Code's Monokai, and I don't see the highlighting.
from vscode-crystal-lang.
faustinoaq
commented on May 28, 2024
~~Unless I change this line to Ruby, other VSCode themes does't recognize the crystal delimiter.~~~
"begin": "(?<=\\{|do|\\{\\s|do\\s)(\\|)",
"captures": {
"1": {
"name": "punctuation.separator.variable.crystal"
}
},Edit: see comment below
from vscode-crystal-lang.
faustinoaq
commented on May 28, 2024
I found a lot of dirty code when I converted .tmLanguage to .json
I'll do a PR fixing this issue.
Internally related to #7
from vscode-crystal-lang.
faustinoaq
commented on May 28, 2024
Fixed on #9
from vscode-crystal-lang.
Related Issues (20)
- Add Crystal Specs to native Testing UI HOT 1
- [Feature] Being able to Ctrl-click a class or method HOT 1
- Error executing Crystal plugin. spawn bash ENOENT in Windows HOT 1
- New release? HOT 20
- Supporting mutiple main files (entry points) for a single project HOT 4
- Hover feature does not work with Windows11 PC and v0.8.4 of the extension (Native Windows Crystal, not WSL) HOT 1
- With compiler path set properly still get error upon opening first .cr file HOT 1
- Dot in comments triggers autocomplete. HOT 3
- Crystalline server crashes if VSCode started with shortcut HOT 6
- Tasks don't support arbitrary files
- Use `spawn` instead of `exec` for formatting
- V 0.9 won't catch some errors HOT 1
- Type on hover missing HOT 7
- Syntax highlight mismatch for methods and variables HOT 3
- do autocompletes to DivisionByZero on ENTER HOT 8
- Non-variables starting with underscore are colored like comments
- Method names that start with a macro interpolation will show gray syntax highlighting HOT 1
- ECR formatting
- Not working when working from a parent DIR HOT 3
- Classes imported from shards throw a "undefined constant" error HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-crystal-lang.