Comments (3)
The duplication of the submodule and function names is intended to make working with directed or undirected Graphs analogical. There would definitely be problems if both namespaces (directed and undirected) are opened but I trust the user to only open one and call functions of the other explicititly (if even needed). Requiring explicit names all the time would make working with the library way too clumsy IMO.
Regarding the duplicate implementation of Vertices.iter and Vertices.map: This could be done both ways. I'd say it's okay for those 2 functions to be duplicate to keep the general structure consistent. Do you agree? It's definitely debatable if not.
from fsharp.fgl.
The duplication of the submodule names in the directed and undirected modules is generally a good idea imho. I just don't know if functions that work generally on all graphs should be hard copied. An opiton to get rid of the copies to have private versions of the algorithms in the general module and use them for the directed/undirected submodules to offer an easy API. Do you see problems with that?
Would also make it easy to diverge for a couple of algorithms whenever the properties of an undirected or directed graph make it possible to optimize internally. It's kind of already done with the usage of a Map as the underlying datatype for the Graph type - it's further away from the original FGL implementation but afaik more performant. What do you think?
from fsharp.fgl.
I removed the code duplication you mentioned in d015d7f
With this I'll close this issue.
from fsharp.fgl.
Related Issues (20)
- [Bug] Undirected.Graph.toAdjacencyMatrix only shows an edge one time instead HOT 3
- GDF files saved by gephi cannot be opend due to formating issues.
- Switch to new buildchain HOT 1
- Vertices module moved into the Graph module HOT 2
- [Docs] Error in example for documentation for Creating a Graph HOT 1
- [Feature Request] Consistent Namespace Naming
- [Feature Request] Modules eigenvector determination
- [Feature Request] Functions to calculate modularity on all available graph models
- [BUG] Directed graph: decompose only removes outgoing edges HOT 2
- [Feature Request] ArrayAdjacencyGraph Namespace names
- [BUG] Edges.fold processes edges twice in directed Graph HOT 5
- Error on creating directed graph HOT 2
- Centrality measures and shortest path HOT 5
- [Docs] `List.init` mistake in AdjacencyGraph tutorial
- [Feature Request] Call undirected edges in FGL.ArrayAdjacencyGraph HOT 1
- [Feature Request] Combine FGL and FGL.ArrayAdjacencyGraph into one Project
- [Feature Request]Add functions to convert FGL Graph into ArrayAdjacencyGraph
- [Feature Request]Add tests for undirected edge calls in FGL.ArrayAdjacencyGraph
- [Feature Request] Function to call complete Vertex List in ArrayAdjacencyGraph
- [Renaming required]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fsharp.fgl.