Enable using a threaded WSGI server about pytest-httpserver HOT 2 CLOSED

hi @delthas ,

Is this related to #263?
Were you able to test that example? :)

I'm ok with adding a kwarg-only boolean flag threaded to HTTPServer.__init__. This could be then used at make_server, in a similar way to self.ssl_context, provided this is the only modification needed..

If there are other modifications needed, I suggest creating a subclass, extracting make_server to a method, which is then overridden. That subclass would do the thread-specific overrides needed (vs. having multiple if self.threaded: blocks).

My main concern is how it performs if there is a handler running in a thread and let's say the client timeouts and the test continues to run. In such case the handler would be still running (eg. handler has sleep(1500)). Threads cannot be stopped (killed) easily, and in the case of pytest-httpserver we want to provide a clean http server instance (which means: no handlers registered, log cleared, no handlers processing anything from the last test, no cross-talk.
So if there's a way, I would suggest waiting (joining) for all the running handlers' threads before we move on to the next test.

So in summary, I'm open to the idea, but we need to do it very carefully.
We can also document and indicate that this is experimental, "do it at your own risk", if needed.

What do you think?

I'm happy to work on the code as well, but it is also ok if you open a PR. Just make sure docstrings are updated.

Zsolt

from pytest-httpserver.

@delthas FYI, your MR has just been relased as v 1.0.11 with documentations in the howto section. Thanks again for your contribution and apologies for the delayed release!

Zsolt

from pytest-httpserver.