Allow using wildcard in request URI about pytest-httpserver HOT 6 CLOSED

I've merged the PR request, thanks for your comments!
I think I'll do a release later today.

from pytest-httpserver.

I've released 0.3.5.
I'm closing this issue in the hope that packages on pypi are also usable (I've already checked, but who knows..). :) If you see any problem, feel free to open a new issue.

Thanks for using this library!

from pytest-httpserver.

Hi,

This is the dup of #34. Please read my answer there.

As it came up from two different people, I think I'll add some basic support for this - however I still do not want to add any routing implementation as it would be a reimplementation of Flask. It means that the handlers will be looked up in a sequential order (in the same order as there were defined) with no respect of how narrow is the match.

What I mean by "basic" is the following:

• accepting a regexp object (eg the object returned by re.compile()), in such case the match will be performed.
• accepting an URIPattern object, which would be defined as an abstract class, and it would have a match() method of it (eg. it would be handled in the same way as the regexp object).

The library itself would have no implementation of the URIPattern class, it would be up to the developer to implement something (eg prefix/suffix matches, glob matching, etc).

from pytest-httpserver.

Thanks for you answer! Just read your answer in #34 and it's great that we are able to do this 👍. But it might indeed be good to also implement a way to also accept regex as that seems a bit more user-friendly. If you need any help I'll be happy to assist implementing it 👌

from pytest-httpserver.

cc: @arturpat

I've submitted the PR #37 to implement pattern matching. Could you please have a look at it?
Obviously I accept any comments on the implementation and also I'm interested if this would make your life easier regarding this library. Having an isinstance on the object returned by re.compile is quite awkward but I could not find any better.

The key points are:

• regexps can be provided by re.compile (this is good for performance, but also to distinguish string from regexp)
• URIPattern is defined as abstract class, so it cannot be instantiated directly, but if you create a subclass and define the match() method, it will be used to match the URI. I was thinking about allowing providing of any callable, but this URIPattern can be parametrized (which will be true in 99% of cases, such as prefix match or glob match), and it is more type safe (in python term: easier to specify a pattern hint, better IDE support, etc)

I also kept the possibility to specify any object whose __eq__ is properly written as I suggested in #34, as I don't want to break any code (unless it is absolutely necessary).

from pytest-httpserver.

Hey,
thanks for getting back to this, that's cool! I will probably try to upgrade and battle-test your change in upcoming months :)

Thanks for developing this great library,
Artur

from pytest-httpserver.