Giter VIP home page Giter VIP logo

Comments (9)

rwv37 avatar rwv37 commented on July 22, 2024 1

Yes, the suppressions are working now. Thanks again.

from exceptionalresharper.

pedromagueija avatar pedromagueija commented on July 22, 2024

@rwv37 which version did you have installed? I've used 0.7.13 with your code sample and it seems to be working properly.

from exceptionalresharper.

rwv37 avatar rwv37 commented on July 22, 2024

I am also using 0.7.13. Also, in case it matters:

Visual Studio 2015 Community, 14.0.25431.01 Update 3
ReSharper Ultimate 2016.2

I just checked again, pasting my code from my earlier comment into a brand new project, and still get the same problem.

from exceptionalresharper.

rwv37 avatar rwv37 commented on July 22, 2024

Incidentally, suppressions for other ReSharper-based things do work for me... just not those coming from Exceptional.

from exceptionalresharper.

pedromagueija avatar pedromagueija commented on July 22, 2024

I'll dig into it. Could you help me and tell me if this works for you:

// ReSharper disable ThrowingSystemException
// ReSharper disable ExceptionNotDocumented
throw;
// ReSharper restore ThrowingSystemException
// ReSharper restore ExceptionNotDocumented

from exceptionalresharper.

rwv37 avatar rwv37 commented on July 22, 2024

Thanks for looking into it.

Same errors when I use your code. Just to be explicit, I'm putting your code into my original example, so now it's:

    public void Blah()
    {
        try
        {
            Console.WriteLine("Doing something");
        }
        // ReSharper disable once CatchAllClause
        catch (Exception e)
        {
            Console.WriteLine("Oh no! " + e.Message);
            // ReSharper disable ThrowingSystemException
            // ReSharper disable ExceptionNotDocumented
            throw;
            // ReSharper restore ThrowingSystemException
            // ReSharper restore ExceptionNotDocumented            }
        }
    }

from exceptionalresharper.

rwv37 avatar rwv37 commented on July 22, 2024

Whoops - just noticed that extra } I have in the final "restore" comment. But taking it out doesn't make a difference.

from exceptionalresharper.

rwv37 avatar rwv37 commented on July 22, 2024

OK, wait, this is weird:

I went into R#'s Extension Manager, and noticed that it said there was an update for Exceptional. So I figured I'd try it out. And the suppressions are now working (both my original ones and yours). Which is great. But! I then went into Extension Manager again, and it STILL says I'm using 0.7.13.

I'm... virtually certain it said 0.7.13 before, too. I explicitly checked it when you asked.

from exceptionalresharper.

pedromagueija avatar pedromagueija commented on July 22, 2024

Wow, ok, weird indeed.
Perhaps a typo in the version. But then now everything is working as expected right?

from exceptionalresharper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.