message is not copied in result of `hydrateRepeated` about froto HOT 3 CLOSED

Yup, looks like a bug & looks like your proposed fix should work. Sloppy of me to not have unit tested this. Feel free to add a test, update the code & send a pull request. Will otherwise try to get to this in a couple of days...

On a note, I'm not entirely happy with this particular routine. I had tried to eliminate construction of the throw-away ref object here by refactoring the entire library to use pass-by-reference (byref) - see this branch: https://github.com/ctaggart/froto/tree/pass-by-reference-and-record-serializer. Would be great to get that working, but I don't think it is possible to eliminate the runtime-error because .NET simply does not support byref and generic parameters

from froto.

I've fixed the above & added a unit test, but there is now an O(n^2) performance issue.

While writing the unit tests, I noticed that repeated fields were not being kept in order (packed-repeated works, though). As a quick fix, hydrateRepeated does an append to the end of the list for every new element added.

Not sure how to fix this long term without adding additional abstract methods to MessageBase, but that's probably going to be the solution.

from froto.

@tathanhdinh - please update your client code to rename hydrateRepeated to hydrateOneRepeatedInstance. Sorry for the inconvenience, but even I was confused at first, thinking that this function would deserialize the entire list of repeated objects (not just a single instance).

from froto.