Giter VIP home page Giter VIP logo

Comments (5)

MichiruKayo avatar MichiruKayo commented on June 11, 2024

Hi, what kind of tracing should be processed? Do we need to log it?
I have checked possibilities of graphql-java instrumentation and we can do following:
extend TracingInstrumentation and track "Begin" of execution/parse/validation/data fetch/field process (no endings here)
and we also have method instrumentExecutionResult that contains all metrics. start/end/total in general and for each field
P.S but this data can not be returned to client due to implementation of spring-boot ... they are simply ignored and not set in result.

from spring-boot-graphql-template.

trioletas avatar trioletas commented on June 11, 2024

Log, yes.
Base-line:
queryName
query
variables
Anything on top is optional

from spring-boot-graphql-template.

MichiruKayo avatar MichiruKayo commented on June 11, 2024

i have concerns regarding Query i have tried to print it one project with real query and...... it was a bit long (about 10000+ characters) log was spammed with it... (
should we truncate then ?

update: i guess we can log everything, and then people decide later what they want.

from spring-boot-graphql-template.

trioletas avatar trioletas commented on June 11, 2024

Don’t truncate anything what’s the point of traces if we lose information.

from spring-boot-graphql-template.

trioletas avatar trioletas commented on June 11, 2024

Also if your project has 10000+ character queries I’m not sure that long traces is your biggest problem. What’s up with that?!

from spring-boot-graphql-template.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.