Comments (11)
It will be soon 😀
from react-async-component.
BTW: The current (new) approach of Apollo's logic to fetch data on the server has been changed. They now call handle each component in the tree so that fetchData
is required on the instance - not on the class. - This actually fixes all the previous issues with HOCs where the fetches were executed multiple times.
from react-async-component.
FYI I am in the middle of a rewrite that will be able to provide a compat layer with react Apollo. Only requiring a single tree walk to resolve the AsyncComponents and Apollo data.🤘
from react-async-component.
Hey @swernerx
I can look at building an Apollo integration layer. It won't work out of the box at the moment no. :(
I plan on doing an integration between this and react-jobs
so the same integration API could be reused for your case too hopefully.
I'll keep you posted if and when I make progress.
from react-async-component.
Thanks! Alternatively it would help to have some simple babel plugin which removes import()
from server side code and replaces it with require().default
or so...
We don't need code splitting on server, right?
from react-async-component.
Interestingly webpack.optimize.LimitChunkCountPlugin
does not seem to affect import()
s. Otherwise that would be a nice thing for server side bundling.
from react-async-component.
Okay my previous statement was wrong. It works. Just make sure to use maxChunks
!= 0 which does not work. With maxChunks = 1
I effectively can disable all import-based code splitting in my app for NodeJS.
from react-async-component.
@swernerx were you able to get withAsyncComponents
and apollo's renderToStringWithData
to play nice with each other in the end? If so could you advise on the solution?
from react-async-component.
@navgarcha You might want to have a look at edgestack - my current Apollo ready development stack. It includes a different async component solution which also supports locales and it works well with Apollo, yes. Needs more fine tuning and stabilization though I figure.
from react-async-component.
@swernerx perhaps i've misunderstood what you were trying todo - i can't see any use of { graphql } from 'react-apollo'
or { createAsyncComponent } from 'react-async-component'
?
from react-async-component.
@ctrlplusb awesome - is this in the next
branch?
from react-async-component.
Related Issues (20)
- if more the one same async components are rendered in same page, only one will be rendered
- Chunk rendered in the server is requested in the client again HOT 1
- Need Help : How can I solve "System is not defined" HOT 5
- Error walking your react tree HOT 1
- No-match routes rendered during async loading HOT 1
- Combining with <link rel="prefetch" /> results in loading async components twice
- Upgrade to support react-async-bootstrapper 2
- App component rendered twice because of AsyncComponentProvider wrapper in RU
- Solved : Flashing LoadingComponent and render twice
- getErrors missing after migration to 2.0.0
- When used with react-hot-loader, async component gets stuck on the loader HOT 3
- Async component not rendering on directly open page
- Client error: Failed to resolve asyncComponent on Safari 11.1
- React.Children.only seems to fail on IE11 HOT 1
- Is it possible to load the async'd components from a custom URL? HOT 1
- Two same simultaneously async components HOT 5
- Informing about React.lazy() HOT 2
- Cannot read property 'helmetInstances' of undefined HOT 3
- migrate to New Context API
- Error async-component, state not reloaded after error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-async-component.