Combination with "fetchData" idea from Apollo GraphQL about react-async-component HOT 11 OPEN

It will be soon 😀

from react-async-component.

BTW: The current (new) approach of Apollo's logic to fetch data on the server has been changed. They now call handle each component in the tree so that fetchData is required on the instance - not on the class. - This actually fixes all the previous issues with HOCs where the fetches were executed multiple times.

from react-async-component.

FYI I am in the middle of a rewrite that will be able to provide a compat layer with react Apollo. Only requiring a single tree walk to resolve the AsyncComponents and Apollo data.🤘

from react-async-component.

Hey @swernerx

I can look at building an Apollo integration layer. It won't work out of the box at the moment no. :(

I plan on doing an integration between this and react-jobs so the same integration API could be reused for your case too hopefully.

I'll keep you posted if and when I make progress.

from react-async-component.

Thanks! Alternatively it would help to have some simple babel plugin which removes import() from server side code and replaces it with require().default or so...

We don't need code splitting on server, right?

from react-async-component.

Interestingly webpack.optimize.LimitChunkCountPlugin does not seem to affect import()s. Otherwise that would be a nice thing for server side bundling.

from react-async-component.

Okay my previous statement was wrong. It works. Just make sure to use maxChunks != 0 which does not work. With maxChunks = 1 I effectively can disable all import-based code splitting in my app for NodeJS.

from react-async-component.

@swernerx were you able to get withAsyncComponents and apollo's renderToStringWithData to play nice with each other in the end? If so could you advise on the solution?

from react-async-component.

@navgarcha You might want to have a look at edgestack - my current Apollo ready development stack. It includes a different async component solution which also supports locales and it works well with Apollo, yes. Needs more fine tuning and stabilization though I figure.

from react-async-component.

@swernerx perhaps i've misunderstood what you were trying todo - i can't see any use of { graphql } from 'react-apollo' or { createAsyncComponent } from 'react-async-component'?

from react-async-component.

@ctrlplusb awesome - is this in the next branch?

from react-async-component.