Comments (3)
The fix for the AFTER hook ordering is simple. Just needed to execute the AFTER hooks prior to purging the context.
Although, this uncovered another issue, which is more intricate. The hooks are not wrapped by an exception trap like the steps are, and they don't have the ability to return an InvokeResult, like the steps do. I would need some help on making that happen.
BTW, this is a great framework! Just needs a little polish. We are getting geared up to use it extensively for ATDD for a massive Qt C++ application. ;)
Thanks in advance for you help! See my AFTER hook execution fix below:
--- a/src/CukeCommands.cpp
+++ b/src/CukeCommands.cpp
@@ -14,8 +14,8 @@ void CukeCommands::beginScenario(const TagExpression::tag_list *tags) {
}
void CukeCommands::endScenario() {
- contextManager.purgeContexts();
hookRegistrar.execAfterHooks(currentScenario.get());
+ contextManager.purgeContexts();
currentScenario.reset();
}
from cucumber-cpp.
Yes, that was my guess as soon as I saw that a new context was being created. I'll look into it on the weekend. Feel free to submit a pull request if you can make your wayin thequite messy tests (started a refactoring with mocks as part of feature #31). Thanks for your help and interest :-)
from cucumber-cpp.
Leaving it open despite pull #43 as a reminder that it needs to be tested.
from cucumber-cpp.
Related Issues (20)
- Rename master branch to main HOT 1
- Add Conan support for cucumber-cpp HOT 1
- [FEATURE] comparing result of performances (upload data in the report) HOT 2
- sudo cmake --build /home/yizhu/cucumber-cpp/ --target features, this command get errors HOT 1
- Is there a working example of cucumber (c cmake, boost) for c++? HOT 5
- Failed tests when checking implementation against common cucumber test suite HOT 2
- README.md has dead link HOT 1
- request a new release HOT 2
- nlohmann-json I think breaks the installation HOT 2
- cucumber.wire ignored (older versions don't) HOT 2
- Update Conformance / Use u2d versions HOT 4
- Minimal CI for Windows
- Full fledged CI for Windows
- Confusing script name run-all.sh HOT 1
- Getting rid of ruby dependency HOT 6
- QTestDriver Implementation not working on Windows HOT 1
- Testing Qt Code which requires EventHandling and UI HOT 3
- Compilation and Library Use HOT 2
- Please add pkg-config support for use with GNU AutoTools (was #237 not merged by mistake?) HOT 13
- Outdated links in readme HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cucumber-cpp.