Giter VIP home page Giter VIP logo

Comments (3)

barneywilliams avatar barneywilliams commented on July 19, 2024

The fix for the AFTER hook ordering is simple. Just needed to execute the AFTER hooks prior to purging the context.

Although, this uncovered another issue, which is more intricate. The hooks are not wrapped by an exception trap like the steps are, and they don't have the ability to return an InvokeResult, like the steps do. I would need some help on making that happen.

BTW, this is a great framework! Just needs a little polish. We are getting geared up to use it extensively for ATDD for a massive Qt C++ application. ;)

Thanks in advance for you help! See my AFTER hook execution fix below:

--- a/src/CukeCommands.cpp
+++ b/src/CukeCommands.cpp
@@ -14,8 +14,8 @@ void CukeCommands::beginScenario(const TagExpression::tag_list *tags) {
 }
 void CukeCommands::endScenario() {
-    contextManager.purgeContexts();
     hookRegistrar.execAfterHooks(currentScenario.get());
+    contextManager.purgeContexts();
     currentScenario.reset();
 }

from cucumber-cpp.

paoloambrosio avatar paoloambrosio commented on July 19, 2024

Yes, that was my guess as soon as I saw that a new context was being created. I'll look into it on the weekend. Feel free to submit a pull request if you can make your wayin thequite messy tests (started a refactoring with mocks as part of feature #31). Thanks for your help and interest :-)

from cucumber-cpp.

paoloambrosio avatar paoloambrosio commented on July 19, 2024

Leaving it open despite pull #43 as a reminder that it needs to be tested.

from cucumber-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.