Giter VIP home page Giter VIP logo

Comments (2)

Sabst avatar Sabst commented on August 19, 2024

Same problem running examples (BoostCalculatorSteps):
Program received signal SIGSEGV, Segmentation fault. 0x00000000005622e8 in cucumber::internal::CukeEngineImpl::stepMatches ( this=0x7fffffffe630, name=...) at (...)/cucumber-cpp/src/CukeEngineImpl.cpp:29 29 engineMatch.id = convertId(commandMatch.stepInfo->id);

Had to fix CukeEngineImpl.cpp:27 this time.
In fact, I returned a const ref in MatchResult and StepMatchesResponse classes, this avoids changing the code everywhere the accessor is called.

The good news is that tests and examples are running now.
Thank you for your work!

from cucumber-cpp.

paoloambrosio avatar paoloambrosio commented on August 19, 2024

I am not having those issues on Linux Mint 13 i386 (the old laptop I'm using now), but it would make sense even without the problems you are experiencing. I started using BOOST_FOREACH recently, so I was unaware of the nasty implications.

I like returning const refrences in getters as well. Since they are all internal interfaces (e.g. we are not breaking our code by doing const_casts!), I see no point in returning new objects there. Feel free to fork the project and submit a pull request to return const refrences for getters :-)

By the way, adding consts to methods was part of a general cleanup I was going to do for issue #31 on which I'm working.

from cucumber-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.