Giter VIP home page Giter VIP logo

Comments (9)

asilvas avatar asilvas commented on May 23, 2024

Bit more info. First of all, the file shouldn't be requested at all, unless I'm missing something. But when it is requested, it is hitting "undefined/domReady.js". The 2nd part probably isn't important, as it is likely due to plugins path not being defined (I kept my example code simple to isolate this issue), but wanted to include just in case.

from curl.

unscriptable avatar unscriptable commented on May 23, 2024

This is easily reproduced in the tests. It seems that curl's simplified make.sh script (which is used to create the compiled versions in the dist/ folder) is too simplistic to handle parent module ids. The real fix would be to start using cram to compile these versions, but for now, I just changed the domReady! plugin's call to the domReady module from "../domReady" to "curl/domReady". Will commit this to dev branch and release it as 0.5.1 after running tests.

from curl.

asilvas avatar asilvas commented on May 23, 2024

Good deal. Figured it was something simple. Thanks!

from curl.

unscriptable avatar unscriptable commented on May 23, 2024

I just pushed 0.5.1 after checking it in the tests. Feel free to test it in your env and close this ticket if it's fixed for you. -- J

from curl.

asilvas avatar asilvas commented on May 23, 2024

You're on fire! I'll close in morning after I verify. Thanks!

from curl.

asilvas avatar asilvas commented on May 23, 2024

Similar issue found with "css" plugin, using 0.5.1.

from curl.

unscriptable avatar unscriptable commented on May 23, 2024

I just verified that the css! and async! plugin have a sightly different issue that manifests itself the same way.

from curl.

unscriptable avatar unscriptable commented on May 23, 2024

Committed a fix to the dev branch: https://github.com/unscriptable/curl/tree/dev. Milestone: 0.5.2.

from curl.

asilvas avatar asilvas commented on May 23, 2024

Verified css! is fixed. Thanks!

from curl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.