Giter VIP home page Giter VIP logo

Comments (4)

dkebler avatar dkebler commented on June 16, 2024

yes it's the when library... I switched to bluebird no warnings.

Seems like cujojs project is dead, many unclosed unresponded issues... :-(.

from when.

briancavalier avatar briancavalier commented on June 16, 2024

Hi @dkebler. The messages you've reported are coming from Node's promise implementation, not from when.js. Here's what when.js's unhandled rejections look like.

I have no explanation for why Node is warning in this case. However, I have encountered a similar situation in another project, in a completely different context. most.js uses markdown-doctest to test the examples shown in all its documentation. As of Node 6.9.1, I get 4 warnings from Node's promise implementation when running the tests, and never got any before:

screen shot 2016-10-28 at 8 53 02 am

Note that markdown-doctest doesn't use when.js at all, and the format in that screenshot is the same as in your example.

So, I don't believe this is a when.js issue, but rather an issue introduced into Node 6.9.1.

from when.

dkebler avatar dkebler commented on June 16, 2024

This started coming up in my code and it happens when a rejection does not fully bubble up the chain. Until one finds and "fixes" them all the warning doesn't go away. For example if you have a returning promise inside another new one and you resolve inside the .then but add no .catch(e=>reject(e)) to the end you will get this warning. It's node's way of saying you have a "broken" chain issue. Like I said bluebird reduce does not throw this warning. I'd take a look rather than blame it on node. I can't use when if it throws this error because it causes my cli not to return to the prompt.

from when.

mikaelkaron avatar mikaelkaron commented on June 16, 2024

This is probably not related but I'll drop it here anyways (nodejs/node#821)

from when.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.