Giter VIP home page Giter VIP logo

Comments (6)

sfolsom avatar sfolsom commented on August 16, 2024 1

Looks good in Sinopia as-is. We can reopen if something comes up.

from qa_server.

chrisrlc avatar chrisrlc commented on August 16, 2024

Current direct lookup deployed to: https://lookup-int.ld4l.org

Current scenarios pass, but I see that I've forgotten to copy over scenario cases from the ld4 cached version. I'll get this pushed to my branch, but let me know if you also want to be able to test those on lookup-int.

Right now search results are sorted alphabetically by label - did we want to use default homosaurus ranking instead?

from qa_server.

sfolsom avatar sfolsom commented on August 16, 2024

Looks great! It's really nice that the context=true is working. In most (all?) cases, I don't think Sinopia is set up to page through alphabetical results from QA, so the only change needed is to switch from alpha to relevancy. Sinopia users are assuming a classic keyword search and tweaking their search strings until they find the most relevant result.

from qa_server.

chrisrlc avatar chrisrlc commented on August 16, 2024

Unfortunate news: sorting by label appears to be the default for ld authority configs. That can be overridden only if there's another field available to sort on. I can attempt to override this logic, but it might be better to do as a separate ticket to "Allow ability to retain default sorting from external linked data service". Do we want to hold off on deploying these changes to prod so that we can work on that change, or do you think that the default sort by label is sufficient for release?

from qa_server.

chrisrlc avatar chrisrlc commented on August 16, 2024

Side note: the current sorting behavior for the homosaurus_direct search results is the same as all the other QA ld direct lookups.

from qa_server.

sfolsom avatar sfolsom commented on August 16, 2024

Yeah, we might have to live with alpha sort for now. I like the idea of a separate ticket for thinking about how to retain relevancy sort.

Are all the tests for Homosaurus in int? When I run the tests, I see only 2 tests (one term fetch and one search for "ze"). https://lookup-int.ld4l.org/check_status?utf8=%E2%9C%93&authority=HOMOSAURUS_DIRECT&compare_with=&validation_type=all_checks.

It would be nice to run these tests (https://github.com/cul-it/qa_server_aws_deploy/blob/5785b8dec982a29ca1171bd6c3e6f03c897b7d87/config/authorities/linked_data/scenarios/homosaurus_ld4l_cache_validation.yml#L16) on the alpha sort to see how well they perform before making a final decision about pushing to production.

from qa_server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.