Giter VIP home page Giter VIP logo

Comments (2)

gsahbi avatar gsahbi commented on September 24, 2024

Had the same #24
I ended up tweaking the code to ignore origin checks if header does not exist.

after all, cors is a ua security enforcement so we have to trust the browser logic.

from nginx_oauth_proxy_module.

gary-archer avatar gary-archer commented on September 24, 2024

Thanks for pointing this out. There is a 1.2.0 release that fixes this issue. You need to set cors_enabled to off as follows for samesite deployments. The origin header will continue to be checked for data changing commands:

oauth_proxy on;
    oauth_proxy_cookie_name_prefix "example";
    oauth_proxy_encryption_key "4e4636356d65563e4c73233847503e3b21436e6f7629724950526f4b5e2e4e50";
    oauth_proxy_trusted_web_origin "https://demo1.example.com";
    oauth_proxy_cors_enabled off;
}

We have made an equivalent CORS_ENABLED environment variable to OAuth Agent components, which should also be set to false in samesite setups.

See these PRs:

from nginx_oauth_proxy_module.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.