Comments (18)
@bnb yup, checking the process - exit code is doable. Thanks for the clarification.
Tricky part is to reproduce the issue.
from good-first-issue.
We're now using Jest!
Some needed tests:
good-first-issue <project> -o
exits appropriatelylog
returns a properly formatted output without anyundefined
(the repo name is especially tricky!)- `require('good-first-issue') operates and returns an object with the correct shape, as expected
from good-first-issue.
@bnb can we add task lists?
I've few comments over the first task. I doubt if it can be tested.
I've raised a question on that repo: sindresorhus/open#109
from good-first-issue.
@hemal7735 I believe it may be on our end rather than opn's end – I less care about checking that the issue actually opened in a browser and more care that when passing the -o flag, the CLI actually exits.
Context: For a while, we weren't exiting and the CLI would continue running without actually doing anything, forcing the user to CMD + C to get out of it.
from good-first-issue.
@hemal7735 and yes, feel free to add tasks!
from good-first-issue.
I believe it was solved with 3cfb8e6 but I'd always like to maintain a check that it's exiting correctly 😬
from good-first-issue.
I would like to contribute to this issue.
from good-first-issue.
anything happened so far with this issue? has this been resolved?
from good-first-issue.
Hey @bnb
Is this still open? I would like to contribute. :)
from good-first-issue.
@iamtabrezkhan feel free - there may have been some things done but improvements/enhancements always welcome.
from good-first-issue.
Hi, Im new at github and my experience qith code is from the last 2 years with some months of innactivity in between.
Is there any task I could do or somethings I need to learn if I only have a small experience in Js, Ruby, Java, C++, Python?
from good-first-issue.
@carlosdeque-s feel free to poke around and try things out. Use the project, if you have an idea about how it could be better create an issue and I'll share feedback on it. If it's an affirmative, go ahead and start working on a PR - I can at the very least give you pointers in the right direction.
from good-first-issue.
hey @bnb Is this still a on going project ? The project seems really interesting.
from good-first-issue.
@zootechdrum I don't actively work on it at this point for no reason other than I have other things I focus on. I could work on it; also happy to work with others to enable them to get improvements and additions shipped and eventually become a maintainer.
from good-first-issue.
هاي
from good-first-issue.
!assign
from good-first-issue.
Hey everyone, I was wondering to get started with open source contribution. I'm an amateur in Python, OCaml, Javascript, HTML and CSS. Can anyone please explain how I can start working on this??
from good-first-issue.
Hii everyone, I want to start open-source contribution. My skills are React, react native and I can also build basic backend for the applications. How can I start and continue open-source contribution?
from good-first-issue.
Related Issues (20)
- Action required: Greenkeeper could not be activated 🚨
- Action required: Greenkeeper could not be activated 🚨
- Handle failed queries HOT 3
- Handle rate limiting HOT 4
- Action required: Greenkeeper could not be activated 🚨
- Action required: Greenkeeper could not be activated 🚨
- Use kleur instead of chalk HOT 2
- Use newline character instead of empty console.log
- Cleanup branches HOT 9
- Start script missing in package.json HOT 1
- [Documentation] Sugestion to Doc
- projects: Remove BigTestjs.io (inactive) HOT 3
- deps(boxen): error with `Docusaurus` output - emoji in title donks up output HOT 1
- [Feature Request]: onboard an ASCII flavoured banner HOT 1
- An in-range update of open is breaking the build 🚨 HOT 3
- An in-range update of commander is breaking the build 🚨 HOT 1
- An in-range update of inquirer is breaking the build 🚨 HOT 5
- Error with 'docusaurus': output issues aren't always from docusaurus HOT 2
- Octokit deprecated warning HOT 2
- Project License HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from good-first-issue.