Comments (8)
I like the idea of giving control to users what they want to search.
GitHub API is rich enough to support some of the features proposed in the this issue.
However,
We need some sort of identifier which can identify correctly if it was meant for Org/Repo/User ? This link has some good info about it.
for example,
-u (User)
-g (Org) [-o is already taken for opening it in a browser]
This would require some good amount of work on CLI side. Might be a major
?
I'm super excited about this 😎
@bnb I know you are kinda busy this week, but we would love to hear your thoughts about this.
from good-first-issue.
I came here to suggest this as well! How about a flow that looks like this:
- Get name of REPO_OR_ORG from `npx good-first-issue REPO_OR_ORG
- If
REPO_OR_ORG
is a special project inprojects.json
, use that query - Else, check if it matches the ol'
owner/repo
string - Use
org:REPO_OR_ORG
orrepo:REPO_OR_ORG
, depending on if it matches
Happy to take a look at writing a PR for this 😊
from good-first-issue.
@JasonEtco I'd be happy to review that PR 😄
from good-first-issue.
@dantehemerson Can you add more details regerding the issue? What is the expectation here? It would help everyone.
from good-first-issue.
Yeah - I was thinking this too. It seems like a reasonable approach would be to default to a query searching for issues with "good first issue" (as this seems to be a standard) and overriding if a custom config exists, rather than only working if a project has been added.
That's how I interpret this; am I on the right track @dantehemerson?
from good-first-issue.
Falling back to good first issue
can be proven a great uplift (we are already doing it in feeling-lucky
, however, this requires some transparency.
We will need to show some sort of message to the user that we are gonna try to find issues with good first issue
label, as it is not in our configuration. If they want they can raise a PR for overrides.
from good-first-issue.
Yes, @DSchau
I was thinking of something like:
good-first-issue owner/repo
for example:
good-first-issue nodejs/node
or if we would like to look for issues in an organization or a user
we would only pass the name:
good-first-issue nodejs
(org)
or
good-first-issue dantehemerson
(user)
This would look at all the owner's projects
We could also search by language:
good-first-issue -l javascript
Maybe it adds some complexity when we execute the command with respect to now, but I think it would have more scope.
We could look for the label good-first-issue
, feeling-lucky
, or others (as long as they are similar). The idea is to have a standard label, but while that happens we could look for the most popular labels similar to good-first-issue
, if the repo does not have this label. We could inform the user the label that was found as @hemal7735 says.
What do you think?
from good-first-issue.
This has been suggested multiple times – definitely not opposed to it. There are also a few additional layers that may be interesting to consider:
- We have a few org (as opposed to repository) searches. Would it be possible to also pass a specific repo to those? We get into some parsing weeds here but it's something that's interesting to think about.
- I'm curious if we'd want to phone home about queries that are being run so we can get metrics on which projects would be good to add. Probably not, but it's something to consider 🤔
- Definitely +1 the concept but I also want to ensure that this module as a
require()
ed module is still useful without the requirement of passing a complex string, object, or array.
from good-first-issue.
Related Issues (20)
- Action required: Greenkeeper could not be activated 🚨
- Handle failed queries HOT 3
- Handle rate limiting HOT 4
- Action required: Greenkeeper could not be activated 🚨
- Action required: Greenkeeper could not be activated 🚨
- Use kleur instead of chalk HOT 2
- Use newline character instead of empty console.log
- Cleanup branches HOT 9
- Start script missing in package.json HOT 1
- [Documentation] Sugestion to Doc
- projects: Remove BigTestjs.io (inactive) HOT 3
- deps(boxen): error with `Docusaurus` output - emoji in title donks up output HOT 1
- [Feature Request]: onboard an ASCII flavoured banner HOT 1
- An in-range update of open is breaking the build 🚨 HOT 3
- An in-range update of commander is breaking the build 🚨 HOT 1
- An in-range update of inquirer is breaking the build 🚨 HOT 5
- Error with 'docusaurus': output issues aren't always from docusaurus HOT 2
- Octokit deprecated warning HOT 2
- Project License HOT 3
- new feature HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from good-first-issue.