Initial review about kprintf HOT 4 OPEN

2.: I added the missing braces in the last commit.
3.: yes, it is intended for 32bit systems. I should probably add a note.
I think we should keep the code as simple as possible and ignore 64bit. What do you think?

from kprintf.

I think we should strive to keep the codebase warning-free. This should also include test builds in my opinion. Is it really more complicated to handle 64 bit pointers ?

from kprintf.

A very simple fix is simply this :

diff --git a/kprintf.c b/kprintf.c
index 09ec9ae..293bb6f 100644
--- a/kprintf.c
+++ b/kprintf.c
@@ -140,7 +140,7 @@ int vfkprintf(kprintf_write_fn_t writefn, const char *fmt, va_list arg)
                 void *p = va_arg(arg, void *);
                 str_buf[0] = '0';
                 str_buf[1] = 'x';
-                int slen = 2 + itoa_hex((uint32_t)p, str_buf + 2);
+                int slen = 2 + itoa_hex((size_t)p, str_buf + 2);
                 int len = writefn(str_buf, slen);
                 if (len != slen) {
                     return -1;

Of course it is no real 64 bit capability but we just want to be able to build our code without warnings.

from kprintf.

I think we should strive to keep the codebase warning-free

I agree.

to the fix: ok for me.

from kprintf.