Issue compiling on gentoo about hidpp HOT 8 CLOSED

Try adding #include <sys/select.h> in the extern "C" section at the beginning of the file.

I will make a patch when you confirm it compiles for you. There may be similar errors in other files. I prefer to make a single patch for all missing include errors.

from hidpp.

@cvuchener got it to compile on my glibc chroot, but another thing is XML_NO_ERROR is apparently now XML_SUCCESS on newer tinyxml2, will try your fix.

from hidpp.

@cvuchener worked. I'm going to need some help though, as the binaries can't interact with my g602 in a meaningful way (prolly uses a differing protocol/profile stuff).

from hidpp.

I pushed the include fix (and a few other commits that I forgot to push).

XML_NO_ERROR is apparently now XML_SUCCESS on newer tinyxml2, will try your fix.

Do you get a deprecation warning? I don't get anything. Fedora 26 has tinyxml2-3.0.0, is it outdated?

The doc tells about XML_NO_ERROR. Both value are present in my header, but no comment tell to use one or the other.

from hidpp.

no, I just got a failure in compilation. I would say its outdated, but I tend to live on the edge. It apparently just no longer exists on my version.

[1/3] Building CXX object src/tools/CMakeFiles/profile.dir/profile/ProfileXML.cpp.o
FAILED: src/tools/CMakeFiles/profile.dir/profile/ProfileXML.cpp.o 
/usr/bin/c++   -I../src/tools/../libhidpp -Wall   -std=gnu++14 -MD -MT src/tools/CMakeFiles/profile.dir/profile/ProfileXML.cpp.o -MF src/tools/CMakeFiles/profile.dir/profile/ProfileXML.cpp.o.d -o src/tools/CMakeFiles/profile.dir/profile/ProfileXML.cpp.o -c ../src/tools/profile/ProfileXML.cpp
../src/tools/profile/ProfileXML.cpp: In function ‘void readButton(const tinyxml2::XMLElement*, HIDPP::Profile::Button&, HIDPP::Macro&, const HIDPP::EnumDesc&)’:
../src/tools/profile/ProfileXML.cpp:193:9: error: ‘XML_NO_ERROR’ was not declared in this scope
    case XML_NO_ERROR:
         ^~~~~~~~~~~~
ninja: build stopped: subcommand failed.

from hidpp.

Latest version is 5.0.1, and the online documentation is very old (2.0.2). I will make the change.

from hidpp.

Nice, glad to have been of assistance there. Do you think we could live chat in some manner to see about getting this particular mouse supported?

from hidpp.

Not right now sorry, maybe in the late afternoon or tonight (UTC+2).

from hidpp.