Comments (8)
Try changing pb = icon_info.load_symbolic_async.end(res);
to pb = icon_info.load_symbolic_async.end(res, null);
from budgie-screenshot-applet.
thanks - this is the result:
kend/Providers/Imgur.vala ../src/Backend/Providers/NilxNil.vala ../src/Backend/ScreenshotMode/ScreenshotAbstract.vala ../src/Backend/ScreenshotMode/Screen.vala ../src/Backend/ScreenshotMode/Window.vala ../src/Backend/ScreenshotMode/Selection.vala
../src/Widgets/HistoryItem.vala:242.22-242.65: error: -3 extra arguments for `Gdk.Pixbuf Gtk.IconInfo.load_symbolic_async (Gdk.RGBA fg, Gdk.RGBA? success_color = null, Gdk.RGBA? warning_color = null, Gdk.RGBA? error_color = null, GLib.Cancellable? cancellable = null)'
pb = icon_info.load_symbolic_async.end(res, null);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)
[4/30] cc '-Isrc/screenshotapplet@sha' '-Isrc' '-I../src' '-I/usr/include/libsoup-2.4' '-I/usr/include/libxml2' '-I/usr/include/glib-2.0' '-I/usr/lib/x86_64-lin```
from budgie-screenshot-applet.
hmm - I've now done a completely refresh download and compile with the original .end(res)
I've used Ikey's recommendation on the meson compilation of --buildtype plain --
I no longer see any vala errors but from the look of things the C transpile has failed in the same place.
FAILED: src/screenshotapplet@sha/src_screenshotapplet@sha_HistoryItem.c.o
cc '-Isrc/screenshotapplet@sha' '-Isrc' '-I../src' '-I/usr/include/libsoup-2.4' '-I/usr/include/libxml2' '-I/usr/include/glib-2.0' '-I/usr/lib/x86_64-linux-gnu/glib-2.0/include' '-I/usr/include/json-glib-1.0' '-I/usr/include/gnome-desktop-3.0' '-I/usr/include/at-spi2-atk/2.0' '-I/usr/include/at-spi-2.0' '-I/usr/include/dbus-1.0' '-I/usr/lib/x86_64-linux-gnu/dbus-1.0/include' '-I/usr/include/gtk-3.0' '-I/usr/include/gio-unix-2.0/' '-I/usr/include/mirclient' '-I/usr/include/mircommon' '-I/usr/include/mircookie' '-I/usr/include/harfbuzz' '-I/usr/include/pango-1.0' '-I/usr/include/atk-1.0' '-I/usr/include/cairo' '-I/usr/include/pixman-1' '-I/usr/include/freetype2' '-I/usr/include/gdk-pixbuf-2.0' '-I/usr/include/libpng12' '-I/usr/include/gsettings-desktop-schemas' '-I/usr/include/libpeas-1.0' '-I/usr/include/gobject-introspection-1.0' '-I/usr/include/budgie-desktop' '-fdiagnostics-color=always' '-pipe' '-w' '-g' '-O2' '-fstack-protector-strong' '-Wformat' '-Werror=format-security' '-Wdate-time' '-D_FORTIFY_SOURCE=2' '-fPIC' '-pthread' '-pthread' '-pthread' '-pthread' '-include' 'config.h' '-DGNOME_DESKTOP_USE_UNSTABLE_API' '-MMD' '-MQ' 'src/screenshotapplet@sha/src_screenshotapplet@sha_HistoryItem.c.o' '-MF' 'src/screenshotapplet@sha/src_screenshotapplet@sha_HistoryItem.c.o.d' -o 'src/screenshotapplet@sha/src_screenshotapplet@sha_HistoryItem.c.o' -c 'src/screenshotapplet@sha/HistoryItem.c'
src/screenshotapplet@sha/HistoryItem.c: In function ‘__lambda9_’:
src/screenshotapplet@sha/HistoryItem.c:1125:12: error: too few arguments to function ‘gtk_icon_info_load_symbolic_finish’
_tmp2_ = gtk_icon_info_load_symbolic_finish (_data7_->icon_info, _tmp1_, &_inner_error_);
^
In file included from /usr/include/gtk-3.0/gtk/gtk.h:120:0,
from src/screenshotapplet@sha/HistoryItem.c:17:
/usr/include/gtk-3.0/gtk/gtkicontheme.h:333:23: note: declared here
GdkPixbuf * gtk_icon_info_load_symbolic_finish (GtkIconInfo *icon_info,
^
from budgie-screenshot-applet.
can you now add the null and try again?
from budgie-screenshot-applet.
didnt work.
I've changed the vala to this
try {
pb = icon_info.load_symbolic(rgba, null, null, null, null);
pb.composite(original_pb, 12, 12, 24, 24, 12, 12, 1.0, 1.0, Gdk.InterpType.NEAREST, 255);
} catch (GLib.Error e) {
warning(e.message);
}
i.e. removed the async - any issues with this?
I've had to change also all the ui files because the required version in gtk3.20
The only other minor issue I see is this in the terminal:
(budgie-panel:2530): Gtk-WARNING **: Theme parsing error: style.css:30:20: '-gtk-icon-effect' is not a valid property name
(budgie-panel:2530): Gtk-WARNING **: Theme parsing error: style.css:82:20: '-gtk-icon-shadow' is not a valid property name
I presume I can ignore these warnings?
from budgie-screenshot-applet.
I've downloaded Ubuntu Budgie 16.04 to resolve all of these issues. I will get back at you when I fix it all :)
from budgie-screenshot-applet.
@fossfreedom Budgie Screenshot Applet Widget is now fully compatible with GTK+ 3.18 and thus with Xenial :). The build problem is no more. I've fixed the css issues and made a separate style for 3.18 so everything looks as it's supposed to now (with some minor differences) :D. I've modified a string so I'll have to wait for translators to update their translations before I push out a new release.
from budgie-screenshot-applet.
\o/ superb job. Thanks - 16.04 users will much appreciate this. :)
from budgie-screenshot-applet.
Related Issues (20)
- Metadata HOT 2
- Screenshot titles do not affect file names
- request: upload local picture HOT 1
- Paint/write on screenshot HOT 3
- Request: Imgur Account Support HOT 3
- AUR package is out of date
- Yaourt installation fails HOT 2
- Screenshot is much darker HOT 1
- build failure on Ubuntu Budgie 18.10
- Budgie 10.4 (developer) crashes on screenshot delete (in the history section)
- [Feature Request] Magnifier Near Cursor
- Can't make selection screenshot in Raven
- [Feature Request] Built-in image editor HOT 1
- 4K issues with "Selection" mode. HOT 2
- Activating window-focus causes not-fullscreen apps to close and even to close the budgie-desktop session, when taking a screenshot
- Can't make the softmare HOT 2
- selecting wrong region when desktop 200% HOT 10
- not recording pointer HOT 2
- Broken in Budgie 10.5 (Arch) HOT 2
- Can't take selection screenshot
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from budgie-screenshot-applet.