Do not use final classes about orm HOT 5 CLOSED

Fixed in v1.0.4. For consustency, I've used Interface suffix.

from orm.

Yes, DM interface will be added. All Databases support DriverInterface, so you can make your implementation if you want. The only trick will be to adapt schema introspection classes, but they are not used in runtime.

from orm.

I guess the biggest problem here is final implementation of drivers. I’ll work to make bridge easier.

from orm.

This is the only place where the manager is used: https://github.com/cycle/orm/blob/master/src/Factory.php#L128-L131

It turns out we should do this using ISP:

namespace Spiral\Database;

interface ProvidesDatabase 
{
     public function database(string $database): DatabaseInterface;
}

And change impl to this:

namespace Spiral\Database;

class DatabaseManager implements ProvidesDatabase, ... { ... }

namespace Cycle\ORM;

class Factory implements ProvidesDatabase 
{
    public function __construct(ProvidesDatabase $dbm, ...) { ... } // Change signature here to ProvidesDatabase interface
}

from orm.

Yes, this sounds about right.

from orm.