object_method_direct wrong in c++ about max-sdk HOT 4 CLOSED

Hi @andreaagostini -- this macro is already defined as you suggest, if I have understood correctly, here:

https://github.com/Cycling74/max-sdk/blob/master/source/c74support/max-includes/ext_obex.h#L508

So perhaps I'm misunderstanding or you are using an older revision of the SDK?

from max-sdk.

Hi @tap,

actually there is a difference between my proposal and the current definition Compare these:
#define object_method_direct(rt, sig, x, s, ...) ((rt (*)sig)object_method_direct_getmethod((t_object *)x, s))(object_method_direct_getobject((t_object *)x, s), __VA_ARGS__) // current version
vs.
#define object_method_direct(rt, sig, x, s, ...) ((rt(*)sig)object_method_direct_getmethod((t_object *)x, s))((t_object*)object_method_direct_getobject((t_object *)x, s), __VA_ARGS__) // my proposal

That is, I suggest that the return value of object_method_direct_getobject() is explicitly cast to t_object*, which is not the case currently. This would avoid a compiler error when compiling as C++.

from max-sdk.

Okay, I see it now and understand. Does it solve the problem to your liking if we change the line @ https://github.com/Cycling74/max-sdk/blob/master/source/c74support/max-includes/ext_obex.h#L511 to the following?

t_object *object_method_direct_getobject(t_object *x, t_symbol *sym);

from max-sdk.

Yes, that should do it!
Thanks,
andrea

from max-sdk.