Giter VIP home page Giter VIP logo

Comments (6)

moodymudskipper avatar moodymudskipper commented on June 27, 2024 1

No, that's fine, we have in the package :

df %>% dplyr::group_by(edge) %>% dplyr::filter(edge %in% comparable.edges) %>% dplyr::group_split()

These calls are all dplyr calls on the same stack but called from the other package's ns so we do want to record them all

from collector.

moodymudskipper avatar moodymudskipper commented on June 27, 2024

Maybe it's non related, but I see in the trace that collector is called twice, which I tried to avoid, so this should be locked into as well :

traceback()
16: eval(call_to_original, new_caller_env)
15: eval(call_to_original, new_caller_env) at collector.R#116
14: collector::collect_and_run()
13: FUN(X[[i]], ...)
12: lapply(.x, .f, ...) at import-standalone-purrr.R#38
11: map(indices, dplyr_row_slice, data = data) at group-split.R#103
10: dplyr_chop(out, indices) at group-split.R#99
9: group_split_impl(.tbl, .keep = .keep) at group-split.R#85
8: group_split.grouped_df(.) at group-split.R#46
7: (function (.tbl, ..., .keep = TRUE) 
   {
       lifecycle::signal_stage("experimental", "group_split()")
       UseMethod("group_split")
   })(.)
6: eval(call_to_original, new_caller_env)
5: eval(call_to_original, new_caller_env) at collector.R#116
4: collector::collect_and_run()
3: dplyr::group_split(.)
2: df %>% dplyr::group_by(edge) %>% dplyr::filter(edge %in% comparable.edges) %>% 
       dplyr::group_split()
1: cogmapr::RelationshipTest(my.project, units = c("Belgium", "Québec"))

from collector.

moodymudskipper avatar moodymudskipper commented on June 27, 2024

We can reproduce outside of the package, group_split always fails:

iris |> 
  group_by(Species) |> 
  group_split()
#> Error in eval(call_to_original, new_caller_env) : 
#>  '...' used in an incorrect context

from collector.

moodymudskipper avatar moodymudskipper commented on June 27, 2024

That's something with lapply(...),

lapply(list(cars), mutate, a = 1)
#> Error in eval(call_to_original, new_caller_env) : 
#>  '...' used in an incorrect context

from collector.

moodymudskipper avatar moodymudskipper commented on June 27, 2024

Well, just the dots in fact :

fun <- function(...) {
  mutate(cars, ...)
}
fun(a = 1)
#> Error in eval(call_to_original, new_caller_env) : 
#>  '...' used in an incorrect context

from collector.

moodymudskipper avatar moodymudskipper commented on June 27, 2024

The code tried to make a lazy binding out of ..., R didn't like that, If we don't try to set is as a lazy binding it removes the failure (still have to check if the value retrieval works ok).

What it means however is that we would always serialize ... even if it's not used. I think it's ok because the dots take trivial space, they just point to bindings we keep the values from only if they're used.

from collector.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.