Giter VIP home page Giter VIP logo

Comments (4)

moodymudskipper avatar moodymudskipper commented on July 21, 2024

We might trigger the fallback if we encounter a corrupted object too. for instance a function with class "data.frame" would at the moment be reconstructed with construct_idiomatic.data.frame() and this will fail.

If we have a is_corrupted_*() function family, every method can start with if(is_corrupted_*(x)) NextMethod(). We can also make these checks optional.

from constructive.

moodymudskipper avatar moodymudskipper commented on July 21, 2024

After #65 it might be as simple as :

if (constructor == "next") NextMethod()

from constructive.

moodymudskipper avatar moodymudskipper commented on July 21, 2024

I think all objects of class list should have a list() constructor, that's we'll fall back to it if the object is corrupted and a list.

More generally :

  • we check if an object is corrupted
  • if it is we fall back on another constructor, by default an atomic constructor (simplest constructor for the atomic type, with adequate attribute reparation)
  • list() will be used for data frames etc, c() for atomic vectors, function for functions etc

In the example of a function with a data frame class, we will find that the data frame is corrupted, and fall back to the function constructor.

Right now we cannot do this because we run construct_idiomatic then repair_attributes, so we'd run the wrong repair_attributes.

To be done after we unite onstruct_idiomatic and repair_attributes

from constructive.

moodymudskipper avatar moodymudskipper commented on July 21, 2024

done with #172

from constructive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.