Giter VIP home page Giter VIP logo

Comments (17)

jasonmunro avatar jasonmunro commented on May 19, 2024 1

Good catch! Fixed in c0db0ae
Thanks!

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

fixed in master

from cypht.

mat-m avatar mat-m commented on May 19, 2024

Hello
I did a fresh translation for french, added it in the language folder, but even a php ./config_gen.php did not update the language list in the settings. What do I miss ?

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

Thanks for doing this! There is a function in the core modules that defines the list of available langs:
https://github.com/jasonmunro/hm3/blob/master/modules/core/functions.php#L50
So once you add to that it should be available in the settings.

from cypht.

mat-m avatar mat-m commented on May 19, 2024

Found and fixed.
Some issues about translations:

  • Date (Mont, Year) in calendar is not translated
  • Some Messages list titles are not translated (although their entry in the left menu is): Flagged, Unread, Everything, All Email
  • In the homepage:

POP3 services are not enabled for this site. Sorry about that!

is not translated, nor the "Update" Link for the timezone

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

Thanks for tracking those down. All of the missing translations you mentioned should now be fixed.

from cypht.

dumblob avatar dumblob commented on May 19, 2024

I just spotted, that the comment on https://github.com/jasonmunro/hm3/blob/master/modules/core/functions.php#L46 doesn't reflect this decision to throw away the Google-translated strings ;)

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

Good catch! Now fixed.

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

mat-m, I would love to merge your corrected French translation when you are ready. Just send me a pull request and I will merge it. Thanks!

from cypht.

mat-m avatar mat-m commented on May 19, 2024

The line 'Add An E-mail Account' => false, has disappeared from en.php and is not translated anymore.
Keys copy and move should be lowercase in language files
We should have an entry for Download (attachments)

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

The problem with the add an email account string, and the copy/move strings, is they are used in multiple places with different capitalization. I'm going to get this cleaned up today. Strings in the lang files that need a leading capital in some cases and lowercase in others will be defined with the capital in the translation file, and I will use css to convert them to lowercase where need be. I will also add the missing download link.

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

Just pushed fixes for everything and merged the latest pull requests WRT to i18n. Thanks everyone for the feedback. If you notice anything else please let me know!

from cypht.

mat-m avatar mat-m commented on May 19, 2024

The gear in front of the profiles name has a tip "Edit" which is not translated
Same applies for Edit, Delete and Send To in local contacts.

Since the translations exist, it is more a problem of using it in the code.

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

Added some new strings today. I think we are getting close to being i18n complete.

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

Another round of strings added to the language files for the latest feature updates

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

Added more strings to the language files. I'm planning a release soon, so if anybody has time to update a language it would be much appreciated!

from cypht.

jasonmunro avatar jasonmunro commented on May 19, 2024

so much for that soon to be created "release" from April 2017! I'm actually thinking about this again, so I will create a more specific issue around translations if need be. I'm trying to remove generic issues that don't get attention and replace them with more specific ones that are easier to deal with, so i"m closing this.

from cypht.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.