Giter VIP home page Giter VIP logo

Comments (7)

charlesetc avatar charlesetc commented on June 25, 2024

Reason just started supporting OCaml 4.07 so it should be somewhat easy to move... actually supporting both 4.07 and 4.08 is harder. I don't think it depends on #7 necessarily but they probably have similar solutions... choosing to compile different code in a PPX depending on the ocaml version?

from relit.

cyrus- avatar cyrus- commented on June 25, 2024

Does Typedtree change a lot between 4.06 -> 4.07 -> 4.08?

If so, a simple solution would be to use cppo in places where we need the code to be different. You can do stuff like this:

#if OCAML_VERSION >= (4, 0, 6)
(* All is well. *)
#else
  #error "This version of OCaml is not supported."
#endif

from relit.

charlesetc avatar charlesetc commented on June 25, 2024

Yeah I think I'd rather use ppx_optcomp so we don't have to introduce tooling to work with another kind of preprocessor. I'm not sure what the actual changes are, but apparently making something like ocaml-migrate-parsetree for typed trees is much harder as they tend to change much more between versions.

from relit.

cyrus- avatar cyrus- commented on June 25, 2024

Ah yeah that looks better, we should use that.

from relit.

charlesetc avatar charlesetc commented on June 25, 2024

We support 4.07 now! But to get 4.06 working we'll likely need to use ppx_optcomp.

from relit.

YonaHope avatar YonaHope commented on June 25, 2024

Newbie here, working with reasonreact...
Is keeping in line with the latest OCaml compiler for bucklescript of any concern?
They seem to be going for 4.06.x, which should be coming up soon.

from relit.

charlesetc avatar charlesetc commented on June 25, 2024

Hey! Sorry it's taken a while to respond. Commit cacd325 is still on 4.06 so you could try checking that out when Bucklescript is ready. It's a little hard to change master to support both 4.06 and 4.08. If there ends up being a lot of interest in using Relit with Bucklescript specifically I'd be happy moving it to 4.06 for a while.

from relit.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.