In the ChatRoomService example, BroadcastAllAsync (x => x.OnJoin) x always NullReferenceException about magiconion HOT 15 CLOSED

it is caused from does not call RegisterStreamingMethod before call at once.
requires OnJoin before Broadcast...
However, null is not desirable, so I'd like to fix it.
thanks.

from magiconion.

So how do I fix this problem now?

from magiconion.

Who calls BroadcastAll?
In the chat scenario, although I think that someone will surely start after Join.

from magiconion.

public async Task<ServerStreamingResult<ChatRoomMember>> OnJoin()
{
  return await GetStreamingContextRepository().RegisterStreamingMethod(this, OnJoin);
}

from magiconion.

Now this problem can not be resolved, there are other ways, I do not know where to modify.

from magiconion.

please show reproduce client code.
below code is works fine.

static async Task RunChat(ChannelContext ctx)
{
    // create room
    var client = ctx.CreateClient<IChatRoomService>();

    var room = await await client.CreateNewRoom("test", "A"); // TODO:IChatRoomCommand sample is old so require await await...

    var result = await await client.SendMessage(room.Id, "foo bar baz");
    Console.WriteLine("Send success:" + result);
}

from magiconion.

public IEnumerator Join(string roomId, string nickName)
{
       var r = client.Join(roomId, nickName).ResponseAsync.ToYieldInstruction();
       yield return r;
}

from magiconion.

Do you need to do two "ToYieldInstruction" here?

from magiconion.

ah, sorry, require subscribe OnJoin before do anything.

from magiconion.

I've fixed sample code and upload v0.5.1.1 includes this fix.
4d1c8af

main fix is add new api, when creating StreamingContextRepository

new StreamingContextRepository<IChatRoomStreaming>(connection, this);

from magiconion.

Sorry, did not see the version update!

from magiconion.

public async UnaryResult<RoomResponse> CreateNewRoom(string roomName, string nickName)
Are you sure you can write this way?
Why the editor that need to add Task , or can not use async.

from magiconion.

this is for C# 7.0 only, if you have to use old c#, change signature to Task<UnaryResult<T>>.
(but for Unity, generates IObservable<T> code).

from magiconion.

public interface IChatRoomCommand
{
           IObservable<UnaryResult<global::ShareType.RoomResponse>> CreateNewRoom(string roomName, string nickName);
}

Does Unity3d need this?

from magiconion.

moc.exe automatically convert and generate interface.
like this https://github.com/neuecc/MagicOnion/blob/master/src/MagicOnion.Client.Unity/Assets/Scripts/MagicOnionGenerated.cs#L369-L381

from magiconion.