Modernize/Fix CMakelists.txt about cytopia HOT 5 CLOSED

I got started on some ways to fix up the CMakeLists file (see: https://github.com/gamedevmarz/IsometricEngine/tree/fix-cmake). However, it appears your find modules are a mix of things found on the internet - so the SDL2_image/ttf ones are quite dated and don't actually create an imported library, whereas the SDL2 one does.

I can update the find modules if you'd like, but this may break your setup until you test it yourself. Changing the hard-coded Windows paths to SDL libraries will also definitely break your setup (the find modules should be all you need).

Ideally, there is no need for the include_directories, and you would have something like:

target_link_libraries(
  ${PROJECT_NAME}
  PRIVATE
    SDL::SDL2
    SDL::SDL2_Image
    SDL::SDL2_Ttf
)

And each library you link with has specified where their include directory is as a property. For example, in the FindSDL2.cmake:

set_property(TARGET SDL2::SDL2 PROPERTY INTERFACE_INCLUDE_DIRECTORIES ${SDL2_INCLUDE_DIR})

from cytopia.

I have tested changes in the fix-cmake branch and they work on Ubuntu 16.04, Windows 10 with mingw, and it appears they are successful on Travis as well. Please test on your own machine, review, and let me know if you encounter any issues.

from cytopia.

It also works for Visual Studio.
Looks very clean, i like what you did there!

We should add to the README that it's now required to set the PATH env variable to the SDL2 Directory. (for windows, if one just downloads SDL2)

On windows, it'd be a nice addition to also copy over the found sdl libraries to the working directory, so the build will work out of the box. (like the resources dir) What do you think about that?

from cytopia.

I've updated the README's build instructions.

As for the second part, I think you mean copying the .dll file over to the build directory? You don't need to copy the .lib over.

I'm not really sure how to do that with CMake. I think find_library only searches for .lib, not .dll? I'd also have no way to test it myself (without installing VStudio) so anything I script would be in the dark.

from cytopia.

yes, i meant the shared libraries. It's not worth the effort.

I think you can merge this! Good workt

from cytopia.