Giter VIP home page Giter VIP logo

Comments (9)

lenards avatar lenards commented on August 16, 2024 1

@xuhang57 - I totally agree that it is a bit hidden. But I just wanted to mention it as we do have some components in place for that functionality.

from troposphere.

lenards avatar lenards commented on August 16, 2024

It depends on how the feature is implemented and whether it is required for instance launch.

It is likely that we would not want to include this in the product. We do not want our community members to have to know about nor managed SSH keys in order to launch instances.

I can get verification from Edwin Skidmore and Steve Gregory on this.

from troposphere.

lenards avatar lenards commented on August 16, 2024

@xuhang57 - one consideration might be to bring in an approach like this, and control it via feature flag.

from troposphere.

steve-gregory avatar steve-gregory commented on August 16, 2024

Agreed with @lenards, this is absolutely worth including as a feature!

  1. Create a configurable "feature flag" in settings/local.py.j2, perhaps something like settings.REQUIRE_USER_SSHKEYS?
  2. Test/verify that when settings.REQUIRE_USER_SSHKEYS = False the functionality is removed and the app works as expected.
  3. Test/verify that when settings.REQUIRE_USER_SSHKEYS = True the new feature is added and the app works as expected.

from troposphere.

lenards avatar lenards commented on August 16, 2024

Might be worth pointing out that settings need to be brought into the app.py view and included in templates/index.html to be fully available to the JavaScript app

from troposphere.

xuhang57 avatar xuhang57 commented on August 16, 2024

@lenards That make sense. Just one thing that I am not quite sure about the use case for you guys But I think the user would like to have their SSH public key in their instances. If that true, I think it might be useful to have a way to ask them to upload the key since the new user probably don't know where to upload their keys (well, we could tell them in the welcome email, admittedly).

@steve-gregory Thanks and yeah, that is a great idea to have the feature flag in the settings. And just like what Andy said, we can grab the boolean and have it in the templates/index.html. I just need some time to figure out how to connect the flag with troposphere/static/js/components/modals/instance/InstanceLaunchWizardModal.jsx so that it knows when to show up the SSH view

from troposphere.

lenards avatar lenards commented on August 16, 2024

@xuhang57 - side note (and to clarify), we do have the ability to upload SSH Keys from the "Settings" page (reachable by clicking on "username" then Settings). Any key present here will be injected, on launch, into an instance.

We just don't allow fine-grain "selection" at launch time.

from troposphere.

xuhang57 avatar xuhang57 commented on August 16, 2024

@lenards Thanks! And sorry I confused you. I meant the current way of uploading the SSH key could be a bit hard for some new users to discover. But I see your point and I agree with you that the selection would not be necessary to have at launch time.

from troposphere.

xuhang57 avatar xuhang57 commented on August 16, 2024

Sure! And my PR is actually using the existing functions for SSH uploading. So not really a new function or a new logic here. Just adding it to be another step in the launching process.

from troposphere.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.