Expose paging variables for GET /v2/account/activities endpoints about apca HOT 11 CLOSED

This looks great.

I need to clean up my branches and merge this into my fork. Then I can play it.

from apca.

Yeah, it's something that is on my TODO list, because I need it too, although not urgently. I looked at it briefly a while back and something about their design put me off. Will take another look.

from apca.

from apca.

Yep, sucks that they don't expose that properly, but perhaps it's for the better. I am importing all transactions into ledger and then have a script that spits out profit/loss per transaction or per-day. It works flawlessly, I have to say (and I wouldn't want to do it on the fly). But as you said it requires me to import fairly regularly because of the 100 item limit (has never been an issue so far, though).

from apca.

That's cool. I took a look at apcaledge. I'm still not sure how you're specifying the trade window.

My system is a lot of intraday trading. So I easily bust through 100 trades in a given day.

I'm also attempting to load the entire ledger at the start of my application, which requires pagination.

from apca.

It won't work in that case. I am relying on any trades not present in the ledger to be within the last 100 ones for the account. I don't do excessive amounts of trading yet, so that's why it has worked out so far. But it's also why I want this hooked up, too, because it will be a limitation eventually. In any case, I am working on getting page_size and page_token hooked up right now.

from apca.

Awesome! I appreciate it.

It's annoying because partial_fill is kinda useless for the ledger P/L from what I can tell.

I'm probably just going to store the ledger as a hash map of order Id and orders. Then sort by the timestamp when it's time to calculate P/L.

from apca.

Partial fills shouldn't matter at all for the ledger, should they? The knowledge of how much you ordered is not present there.

Here is what seems to be a working version: https://github.com/d-e-s-o/apca/tree/topic/paging

Feel free to give it a spin. Will hopefully polish and merge it by the weekend. Not sure if I'll cut a new release immediately, though.

from apca.

Your branch works great!

from apca.

Awesome. Thanks for trying it out.

from apca.

Change got merged into master now.

from apca.