subscription Precondition failed about pioneer HOT 13 CLOSED

The error occurs here, and just in 2.12.0 they changed

    public func onText(_ callback: @escaping (WebSocket, String) -> () {
        self.onTextCallback = callback
    }

at

   @preconcurrency public func onText(_ callback: @Sendable @escaping (WebSocket, String) -> ()) {
        self.onTextCallback.value = callback
    }

from pioneer.

I'll look into it, thanks for reporting

from pioneer.

It worked fine on Chrome, but I did check that it does fails on Safari and Firefox. I think I narrowed it down to the fact non-Chromium browser doesn't like it when a single path / endpoint is used for http and websocket. I'll made an update where you have provide a separate WebSocket endpoint.

I didn't get the Precondition failed error in both cases though, the server runs with no issue. Although, I am no running the server in debug mode on Xcode.

from pioneer.

I think v1.2.2 fixes the issue, and WebSocket should work now in Firefox and Safari.

Although, if connecting to WebSocket using the same path for HTTP poses a problem, there's now the "/graphql/websocket" endpoint that only handles WebSocket and should be more consistent.

Let me know if the precondition failure happen again, I have not been able to reproduce that exact error message, I'll close this issue by tommorow if everything works fine

from pioneer.

In Firefox and Safari now works. But the Precondition failed error is still there, I tried to run it in the terminal, it has the same error.

from pioneer.

Websocket-kit version 2.11.0 has no Precondition failed error, but no connection, apollo sandbox gives error Unable to reach subscription server

from pioneer.

What version of websocket-kit were you using before that gives the precondition errors?

from pioneer.

From version 2.12.0 the error Precondition failed

from pioneer.

I see, I haven't checked if Pioneer is working perfectly with the latest version of Vapor (and subsequently WebsocketKit). I assumed nothing should be breaking since it's not a major update.

from pioneer.

Cheers, I'll update the dependencies version Pioneer is using and fix the usage of that function

from pioneer.

yep current usage of the onText callback would fail because it is called from a Task

from pioneer.

Alright, I think v1.3.0 should resolve this issue. I bumped up all versions of dependencies for this library to their latest non-major. Unfortunately, I also have to drop support for Swift 5.5 since SwiftNIO and Vapor did the same

from pioneer.

Feel free to re-open this issue, if the problem still persist

from pioneer.