Crash in multiplayer. about enchantmentrevealer HOT 5 CLOSED

Without digging into this very far, I have a fairly good suspicion of what happened. I'd guess that hypixel is changing something about how enchanting works? EnchantmentRevealer depends on being able to perform exactly the same calculations as the server for figuring out enchantments. It still shouldn't crash, of course, but if the client can't redo the same calculations the best it will be able to do is fall back to the default GUI.

from enchantmentrevealer.

Not only did it not fall back to the default GUI, it also crashed.

from enchantmentrevealer.

Yes. What I meant was that the best it can theoretically do is fall back to the default GUI. It doesn't have code to try and handle this case yet (server modded to do different enchantments), so I'm not surprised that it doesn't work right currently. I'm a little surprised that it crashed, but hopefully that will make more sense when I dig into it more.

from enchantmentrevealer.

OK, (if you still care) v1.2 has a patch that avoids the immediate cause of the crash, although I'm not entirely sure what led up to that field never being set (and I can't reproduce the behavior), so I'm not 100% certain that it will eliminate similar crashes in the future.

The best bet remains to disable EnchantmentRevealer if you're on a server that radically changes how enchanting works.

The version you reported this on was Minecraft 1.8.9, and I didn't backport v1.2 that far, because between 1.8.9 and 1.9 there were significant changes to how enchanting works. If you're still playing 1.8.9, I can add just the one crash-fix patch and see if that improves things.

from enchantmentrevealer.

Oh I still care a hell about this mod. I'ma have me some fun with this!

That back-port would be nice, too.

from enchantmentrevealer.