Giter VIP home page Giter VIP logo

Comments (16)

vancwa avatar vancwa commented on June 18, 2024

I am using the latest version (3.2.0.16) and am wondering if the CM aware feature within ImageGlass is enabled automatically by default, or if there is some software setting that must be user selected first before it is enabled. How do I know it's working? I have established a color profile between my laptop and a front projector unit using X-Rite calibration tools. I manage image competitions in a photo club and CM is very important.

from imageglass.

d2phap avatar d2phap commented on June 18, 2024

Hi @vancwa, @Eckso

Since ImageGlass v2.0.1.5, CM feature has been enabled automatically by default. ImageGlass will auto-detect embedded color management profile. You can compare ImageGlass color to Chrome / IE / Photoshop... it will be same. The new Win 10 Photos app is still not supported CM.

You can check issue #17 for further information and download sample image.

from imageglass.

markdv77 avatar markdv77 commented on June 18, 2024

Even latest version (now 4.5.11.27) does not appear to use/honor monitor profiles. (I calibrate my monitor using an X-Rite iDisplay.) I can clearly see Images (simple sRGB jpeg) opened in ImageGlass have different - esp. more saturated - colors then when opened in Photoshop or "chrome --enable-monitor-profile". Which makes it unsuitable to view/show edited photo's.

Would be nice if I could get accurate colors from it too.
For more casual image image viewing I still really like ImageGlass, so "thank you!"

from imageglass.

d2phap avatar d2phap commented on June 18, 2024

Hi @markdv77

ImageGlass enables sRGB profile by default: https://github.com/d2phap/ImageGlass/blob/master/Source/Components/ImageGlass.Core/Interpreter.cs#L100

For the monitor color profile, I will invest my time.

from imageglass.

Sandros94 avatar Sandros94 commented on June 18, 2024

So for the monitor color profile is still under development right?

from imageglass.

d2phap avatar d2phap commented on June 18, 2024

To do:

  • Add option to select *.ICC profile file.

from imageglass.

d2phap avatar d2phap commented on June 18, 2024

Implemented Color Management.

  • Support some built-in color profiles
  • Allow to select a custom color profile *.icc
  • Option to apply the color profile to all or only the images with embedded profile, it's unchecked by default.
  • Use color profile sRGB by default

It's ready for testing in IG Moon 5.5.12.8
https://imageglass.org/moon

image

from imageglass.

sboukortt avatar sboukortt commented on June 18, 2024

Nice progress, thanks!

Could you perhaps just clarify what happens exactly for images without an embedded profile? Looking at the code, it seems that it simply calls “AddProfile” once on the image, which doesn’t sound like it would perform any colorspace conversion (after all, one needs two colorspaces for that).

Maybe what is needed is an option to specify the default colorspace for images without an embedded profile? (I would assume that sRGB would be a typical choice.) You would then:

  1. AddProfile(the_default_image_profile_which_would_often_be_srgb) if the image doesn’t have a profile, and then
  2. AddProfile(the_monitor_profile) unconditionally.

(https://stackoverflow.com/a/18918798)


It is also not entirely clear to me why magicImg.ColorSpace = imgColorProfile.ColorSpace; is needed. Is it, really?

from imageglass.

d2phap avatar d2phap commented on June 18, 2024

Hi @sboukortt
Thanks for the link. I forgot the "two colorspaces"!
Also updated the IG Moon.


It is also not entirely clear to me why magicImg.ColorSpace = imgColorProfile.ColorSpace; is needed. Is it, really?

Sometimes, the color space of this:
magicImg.GetColorProfile().ColorSpace
and this:
magicImg.ColorSpace
are not same (Example: #430), that's why I need to correct it.


For images without an embedded profile:

  • If isApplyColorProfileForAll = false,
    • IG will skip the Color Management processing
  • If isApplyColorProfileForAll = true,
    • IG will assign a default Profile sRGA to the image,
    • then apply the Color Profile from user settings.

from imageglass.

Dogway avatar Dogway commented on June 18, 2024

Not working for me on ImageGlass_Moon_5.5.12.8, the "Apply also for images without embedded profile" is checked with sRGB as the fallback. Images look darker than in color managed viewers. I'm on Win7 SP1, if that helps. Thanks for the updates.

from imageglass.

d2phap avatar d2phap commented on June 18, 2024

Hi @Eckso
Can you attach your file? Thanks

from imageglass.

Dogway avatar Dogway commented on June 18, 2024

Actually any image without an embedded color profile.
cineon
imageglass

from imageglass.

d2phap avatar d2phap commented on June 18, 2024

Hi @Eckso
I can't see any difference of ImageGlass and other apps (MS Photos, Chrome,...), even in your screenshot.

from imageglass.

Dogway avatar Dogway commented on June 18, 2024

Blacks are crushed, you can see it easier if you open the images in diferrent tabs and switch over back and forth. This is ImageGlass.
cineon imageglass

from imageglass.

d2phap avatar d2phap commented on June 18, 2024

Hi @Eckso
Your image contains an embedded profile.
image

I opened this image and compared ImageGlass to Chrome, Firefox, MS Photo, Adobe Photoshop Express. The difference is the brightness of the girl's neck area.

  • the image looks same in ImageGlass, Firefox, MS Photo, Adobe Photoshop Express.
  • the image is a bit brighter in Chrome.

So I think ImageGlass displays the image correctly.

from imageglass.

Dogway avatar Dogway commented on June 18, 2024

PrintScreen or the Snipping tool is not color managed so in order to show what I see I have to interpret the image as Display referred and then convert to sRGB so you can see the same. I think the problem is because I use a calibration profile for my monitor and ImageGlass has issues converting to display space. Thanks for the help.

from imageglass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.