Comments (4)
Sorted by y-value, or not sorted by x-value? If you are you asking whether the line generator should automatically sort the input the x-value, the answer is definitely no because there are some cases where you don’t want this behavior.
However, I could see it being useful to have a line.sort accessor which defaults to null, and lets you specify a comparator. If the comparator is specified, the data would be sorted using the specified comparator before the points were generated and passed to the curve. (I could also imagine a sortX or sortY accessor which sorts on the computed points, but then you’d have to buffer the points and it’d be a bit more work, and I think sorting the data is probably more sufficient.)
The line generator would need to sort a copy of the data, though, so as to avoid modifying the input. So even if we added this, it’d probably be better if the caller sorted the data before passing it to the line generator. So, I guess I’m inclined to not add this feature since it perhaps encourages inefficient code.
from d3-shape.
Sorry, my question was not clearly stated.
You can look at the image below, I just want to draw a line of "vertical layout" which is generated by points sorted by y-value.
And I use d3.line with the curve factory d3.curveMonotone. The the result line is strange. So I want to know do you have any plan to support this kind of line?
from d3-shape.
Okay, so your query is specifically in regards to curveMonotone, then, which “[assumes] that the input data is monotonic in x.”
We could have distinct curveMonotoneX and curveMonotoneY that are equivalent except one requires monotonicity in x while the other requires monotonicity in y.
You can also workaround this restriction by switching the x and y of your line as input to the line generator, and then transform the resulting output (using an SVG or Canvas transform) by reflecting over the y=x line. But that’s a bit tedious.
from d3-shape.
Fixed in 0.5.
from d3-shape.
Related Issues (20)
- Arc - Inconsistent error notification when invoked via fluent function calls vs invoking with data HOT 1
- Dynamic smoothing interpolation HOT 2
- Possible typing issue or a missing example (How to write a custom accessor?) HOT 1
- lineGenerator fail
- es5 to es6+ syntax? HOT 1
- The pie arguments problem HOT 1
- d3.arc startAngle and endAngle are switched when startAngle > endAngle HOT 8
- the BumpRadial curve only works with two-point lines
- Needs connection to me not fast enough!
- How does Catmull Rom work with a Bézier curve? HOT 2
- The types for Arc are incorrect HOT 1
- Unexpected arcs when corner radius is nonzero HOT 1
- curveBumpX creates a circle in Chrome if applied to a straight line. HOT 2
- How to add pointer effect to the shape? HOT 1
- running tests with d3-shape HOT 1
- Configurable precision for generated path data HOT 1
- startPadAngle and endPadAngle HOT 4
- Curve Natural gets outside the svg HOT 1
- add optional angle radius parameter in curbeBezier `curveStep` curves HOT 4
- option for arc's curve precision
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3-shape.