Giter VIP home page Giter VIP logo

Comments (5)

eduardoboucas avatar eduardoboucas commented on July 30, 2024 1

The various operations need to return a rejected Promise if a connection with the database can't be established (i.e. readyState isn't 1)

Actually, I don't think we need this. We're talking about an in-memory database, so in theory the connection will always be available. We could have issues when trying to persist to disk, but that doesn't happen when the model methods are called, so a rejected Promise won't help us here.

Do you concur @jimlambie?

from api-filestore.

jimlambie avatar jimlambie commented on July 30, 2024

I agree with everything ❤️

from api-filestore.

jimlambie avatar jimlambie commented on July 30, 2024

With regard to the stripping out of internal properties, this part was supposed to instruct API how to handle the issue:

https://github.com/dadi/api-filestore/blob/master/lib/index.js#L56

However, I'm happy for them to be removed from the documents before returning.

from api-filestore.

eduardoboucas avatar eduardoboucas commented on July 30, 2024

Removed that item from the list, as it's now being handled by API in dadi/api#369.

from api-filestore.

eduardoboucas avatar eduardoboucas commented on July 30, 2024

👴

from api-filestore.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.