[BUG] Game crashes when opening Creative Menu about spectrum HOT 25 CLOSED

Implemented in e37a777

from spectrum.

The Spectrum ones besides Resonance have that already. ✅
Disabling Resonance will break progression anyways, so having an error in the log will do more good than harm.

from spectrum.

1.7.3 has been having issues running on 1.20.1 with Quilt for uncertain reasons. Fabric should be working fine, if you're able to switch launchers.

from spectrum.

1.7.3 has been having issues running on 1.20.1 with Quilt for uncertain reasons. Fabric should be working fine, if you're able to switch launchers.

you mean loaders

from spectrum.

Can you try without Polymer, please?

from spectrum.

1.7.3 has been having issues running on 1.20.1 with Quilt for uncertain reasons. Fabric should be working fine, if you're able to switch launchers.

It's not an issue with Quilt by itself. Honestly it very rarely is for Fabric mods. I've loaded both versions of 1.20.1 using Quilt and they both work fine.

from spectrum.

I am having this issue and i am using fabric loaded. I removed it and my mod pack is working again. Modpack i am using is Saphsgamingworld on curse.

from spectrum.

Can confirm. Error is happening on Fabric.

from spectrum.

Fabric 1.20.1
Spectrum 1.7.6

Encountering the same error. Attaching the crash log.
crash-2024-02-20_22.56.48-client.txt

EDIT: I also have the following mods: AE2 15.0.20 / Alloy Forgery 2.1.2 / Botania 443 / REI 12.0.684 / Shimmer 0.2.0.

from spectrum.

Does it crash every time when joining the first world or loading the game?

Since I could never reproduce it, try removing mods until it magically starts working.
Once I know how to get it to crash myself I'm sure it will be easy to fix.

from spectrum.

Nope, it only crashes when I enter my inventory in creative mode. Let me try what you suggested and see if I can find the issue. I'll also test a superflat world to see if the client crash still happens. (after I watch the Nintendo Direct of course 🎮)

from spectrum.

👀 Oh yes. I like your priorities.
Thanks a lot!

from spectrum.

Alright, so I found that it's an issue between Spectrum and Enchancement.

I'm using Enchancement 17 (with ToolTipFix 1.1.1 dependency) and Spectrum 1.7.6 / Revelationary 1.3.7 / Patchouli 84 / Trinkets 3.7.1.

from spectrum.

Oh man, not again. Thank you.
I am starting to get really tired of that mod.

from spectrum.

Of course! I guess it's not the first time you've run into a problem with this mod? 😓

from spectrum.

Unnecessarily rude comment aside...

I have now fixed this bug, it was an oversight since my code didn't expect items to be pre-enchanted in the creative tab. Are there any other issues specifically with Spectrum that would need to be addressed before I should release? I assume some of the items come pre-enchanted when crafted, which will assign them a random one (from vanilla or Enchancement, once I push that commit) if the given enchantment is disabled. Do any items come pre-enchanted with more than one enchantment? Are there any actual bugs? This is the first time I've had anything related to Spectrum reported to me, so I don't know anything that may cause problems.

from spectrum.

there aren't any items that come pre-enchanted with more than one enchantment afaik but there are 2 items that can switch between enchantments, which may be something to look out for

from spectrum.

Which items?

from spectrum.

the Malachite Workstaff and the Glass Crest Workstaff

from spectrum.

I had issues with Enchancement with other mods in the past, namely DaFuqs/EnchantmentGroups#8. The one mixin that mod uses would never fire, but since Enchancement's Github mentions versions lower than the most recent release should not get reported and will never be fixed, am unable to do something about it myself, despite really wanting to.
I even wanted to write a pull request to improve compat on Enchancements side, but since there is just a single branch, I can't PR it.💀

To address your questions and explain some things

• Some items use vanilla enchantments for doing additonal stuff. Some examples:
  • The Ender Splice uses Unbreaking to reduce the change for it to break on use, scaling with level
  • The Knowledge Gem uses Quick Charge and Efficiency to increase XP capacity and transfer speed, scaling with level
  • The Glass Crest Greatsword has an AoE ground slam attack, which scales on Sweeping Edge
  • The Takeoff Belt uses Feather Falling to reduce Fall damage for it's boost jumps
  • This is done to give vanillas enchantments more uses and to not dilute the enchantment pool with highly specific enchantments
• Some items are listed with >1 enchantment in the creative menu. I went through the list of items for all that are listed preenchanted with >1 enchant:
  • Ender Splice (Unbreaking III, Resonance, Indestructible)
  • Knowledge Gem (Efficiency V, Quick Charge III)
  • Bottomless Bundle (Power V, Curse of the Void)
  • Takeoff Belt (Feather Falling IV, Power V)
  • Of course that's just for the creative menu which this crash is about. Ingame, lots of items benefit from having more. The Exchanging Staff is listed 4x for ease of use, for example (no enchants, fortune, silk touch, resonance)
• Spectrum supports nbt on recipe outputs, which is used to give some items enchantments, when crafted
• Like the others already mentioned, Some items come with the ability to hot-swap enchants (Fortune, Silk Touch & Spectrum's Resonance on the Workstaffs)

from spectrum.

Oh interesting, I've seen a bunch of people in my discord say Enchantment Groups works fine. Unfortunately yeah I don't support older versions since managing quite literally a dozen mods over multiple versions of Minecraft is... a lot of work, for little to no gain 😅

Thank you for the list! I think for the items that use vanilla enchantments, I'll just not have them added since there's not really an equivalent (and Enchancement tries to lower the power ceiling anyway), but at least for the Workstaff items I added specific compat which I think makes reasonable sense if Fortune is disabled. This only accounts for Fortune being removed, which is the default config, but I think that's fine since most players only play with either the default config or all enchantments enabled :p.

Right now I have pre-enchanted items simply just remove the enchantments if they're not part of the game, I don't think it makes too much of a difference, but some special changes are:

• Ender Splice: durability is outright removed, so Unbreaking and Indestructible are pointless (and I've added Indestructible to the disallowed enchantments list by default)
• Knowledge Gem: Since transfer speed is quality of life, the item has Quick Charge built in without actually having the enchantment. Efficiency is still required for storage space
• Glass Crest Greatsword: AOE slam doesn't seem to function without Sweeping Edge, so the item has Sweeping Edge built in without actually having the enchantment
• Takeoff Belt: Funnily enough has the exact same function as Bouncy, and they stack, so I think I'll keep it unenchanted lol. There are plenty of ways to avoid fall damage in Enchancement, so Feather Falling isn't necessary
• Bottomless Bundle: Since the storage space is quality of life, the item has Power built in without actually having the enchantment
• Razor Falchion: Has Scooping instead of Looting as the default enchantment

*The items that have enchantments built in without actually having the enchantment only have this effect if the enchantment is disabled

Obviously a bunch of enchanting recipes fail to load since some enchantments don't exist, but those are only in the log and afaik don't break anything in gameplay.

The only other issue I can think of the is Lucky Pickaxe, which does nothing since Fortune is disabled. Do you have any ideas on what it could do?

from spectrum.

Sorry to keep you waiting.

• The changes sound perfect, within the realms of possibility.
• For the Lucky Pickaxe, Molten makes the most sense, to complete the Silk Touch-Molten-Resonance set the workstaff has.
• I will add load conditions for the enchanting recipes, so they do not fail to load on startup

from spectrum.

Thank you! The third point will make my life easier haha, I have a very annoying mixin to just ignore the recipe, but it doesn't work for everything. I'll add Molten to the Lucky Pickaxe

from spectrum.

Thanks! I also suggest doing it for the Spectrum enchantments in case they're disabled (indestructible and the autosmelt one are disabled by default)

from spectrum.

Seems to work! The only remaining problem is Enchantment Upgrading is pointless with Single Level Mode since all enchantments only have 1 level, is there a safe way I can disable them from loading? I had a complicated setup that mixined into both the recipe manager and the recipe sync packet, but if there's a cleaner way then I'd rather do that.

from spectrum.