Comments (1)
@JoJo10Smith thanks for the report.
Yeah this is a bit of a hard one. We decided to use extra_kwargs
since it would otherwise require listing all possible kwargs in the class since we're using dataclasses (AFAIK). That seems hard to scale/ensure it's right?
So extra_kwargs
I think is the happy medium, but it does mean the API doesn't 1-1 map. That said, I think extra_kwargs
helps someone else who comes to read the code, as it makes it clear these kwargs are extra and likely specific to some use case... versus you having to check the function signature to understand what is used, and what is being passed on under the hood...
I'll noodle on this for the week, but I'm leaning towards extra_kwargs
. Thoughts?
from hamilton.
Related Issues (20)
- Add sources for missing Polars inputs
- Slack notifier. Have one that can notify a slack channel on error.
- Error cleanly when no output requested using .materialize
- Add xarray example
- `check_output_custom` could pass the information about the feature definition to the output validators HOT 4
- Pandas spss HOT 1
- Streamlining materializer definition HOT 1
- Lifecycle adapter for automatic schema evolution
- Adapter mapping types to pyarrow
- `.visualize_execution()` doesn't show config nodes
- Improve API for `.execute()` all nodes HOT 10
- pandas fwf
- TDQM hook with overrides HOT 2
- Deprecate dependency on `networkx` for `sf-hamilton[visualization]`
- `__repr__` of `HamiltonNode` is hard to read
- `Config` node missing from legend
- Add `Builder.with_materializers()`
- `UX` Hamilton Project
- Decorator like `@subdag` that works with async functions HOT 7
- chore: Remove numpy dependency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hamilton.