Indexing valve, weather adjustment. about sip HOT 4 CLOSED

It looks like you might need to change line ~283 in helpers.py. Probably to something like:
gv.rs[sid][1] = (gv.now + gv.rs[sid][2]) * plugin_adjustment()
To understand what the variables are see gv_reference.txt in the OSPi directory.

from sip.

didn't seem to effect anything. I see the values are:
gv.rs run schedule (list [scheduled start time, scheduled stop time, duration, program index])
but I don't see how they would effect my "until" time for that loop.

if you see my program the rain delay is adjust start time and duration and each loops end time but the "Until" is still 2200 so as the duration increased now only 3 loops get done until 2200 where i had it calculated to 5 to loop through my zones.

from sip.

Oh right. The "until" time is a cut off. anything scheduled to start after that time will not run. I think the weather plugin needs to be changed so that it will only reduce the run time of programs and not increase them depending on conditions. That is, if there is no precipitation the programs will run at 100% of their scheduled time, If there is precipitation the programs should be shortened to compensate for the extra water. I did not write the plugin and have not looked at it closely but I remember seeing something about increasing run times past 100% and thinking that was a bit backwards.

from sip.

Cleaning up old open issues. The plugins have been moved to:
https://github.com/Dan-in-CA/ospi_plugins

from sip.