Giter VIP home page Giter VIP logo

Comments (28)

DanBloomberg avatar DanBloomberg commented on July 17, 2024 3

Thanks :-)
Sigh. A bunch of stuff came up. New plan: 1.84.0 this weekend!

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024 2

Finally done. 1.84.0 is released

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024 1

Thanks :-)

I was just thinking about it today. I'll try to do it tomorrow.

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024 1

ok, I figured it out :-)

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

I would like to do it this month (November).
Do you have any concerns or suggestions?

from leptonica.

amitdo avatar amitdo commented on July 17, 2024

Do you have any concerns or suggestions?

No. I just wanted to know what's your plan.

from leptonica.

amitdo avatar amitdo commented on July 17, 2024

Dan, just a reminder, in case you forgot about your plan.

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

had to delete it (screwed up)

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

should be ok now

from leptonica.

stweil avatar stweil commented on July 17, 2024

The GitHub release is still missing. Should I create it based on the tagged release?

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

I had to delete it again. I forgot to commit some documentation changes (to README.html, version-notes.html) when I did the initial release.

So I committed them. But when I tried to release with the same tag 1.84.0, it keeps using the old source from before the last commit. Do I need to use a different tag, like 1.84.1?

from leptonica.

stweil avatar stweil commented on July 17, 2024

Either tag 1.84.1, or delete the existing 1.84.0 and create a new 1.84.0 based on the latest commit (that's what I would suggest).

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

how to delete the 1.84.0 tag?

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

finally, I think 1.84.0 is now correct

from leptonica.

stweil avatar stweil commented on July 17, 2024

Yes, it looks good. Merry Christmas!

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

And Merry Christmas and relaxing holidays to you.

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

Well, this is inconvenient. Look at the win64-cmake failure in jp2kio.c:
:\a\leptonica\leptonica\src\jp2kio.c(938,5): error C2198: 'opj_stream_set_user_data': too few arguments for call [D:\a\leptonica\leptonica\build\src\leptonica.vcxproj]

Can we get rid of that compiler conditional from years back and always use the 3 arg call to opj_stream_set_user_data() ?

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

@stweil
That conditional seems like a dangerous hack, anyway. And I think the 2 arg version was changed to a 3 arg version at least 6 years ago, maybe more.

from leptonica.

stweil avatar stweil commented on July 17, 2024

Yes, I also think it's time to remove that old code. But that's not urgent and can even wait until next year. :-)

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

Good to know. It is rather funny that this just happened for the first time on the release master.

from leptonica.

amitdo avatar amitdo commented on July 17, 2024

Thanks Dan!

from leptonica.

amitdo avatar amitdo commented on July 17, 2024

Jeff will hopefully be able to work through the dependencies and build a Debian release in time for Ubuntu 24-04.

CC: @jbreiden

from leptonica.

amitdo avatar amitdo commented on July 17, 2024

https://www.omgubuntu.co.uk/2023/10/ubuntu-24-04-release-date-set-for-april-25-2024

from leptonica.

amitdo avatar amitdo commented on July 17, 2024

I had to delete it again. I forgot to commit some documentation changes (to README.html, version-notes.html) when I did the initial release.

Many projects document the release process including the files that need to be updated.

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

I haven't done it, but it seems like a good idea to list those files, and I'll do it in version-notes.html for the next release.

from leptonica.

stweil avatar stweil commented on July 17, 2024

Good to know. It is rather funny that this just happened for the first time on the release master.

That was simply bad luck. The old code always failed with OpenJPEG versions x.y.0 because checking for OPJ_VERSION_MINOR == 0 always had been wrong (it should have checked the major version, too). So as soon as the build environment updated to OpenJPEG 2.5.0, it failed again (like it might have done for 2.1.0, 2.2.0, 2.3.0 and 2.4.0 in the past). It's good that this is fixed now.

from leptonica.

amitdo avatar amitdo commented on July 17, 2024

Right now, I don't see any progress going on in Debian:

https://tracker.debian.org/pkg/leptonlib

So unless things change within the next 3 weeks, Ubuntu 24.04 will stay with Leptonica 1.82.

from leptonica.

DanBloomberg avatar DanBloomberg commented on July 17, 2024

I have discussed this with Jeff, and due to a confluence of obligations over the next few months, he will not have time to make a new Debian release of leptonica.

I don't think it's a big deal, and he will do the upgrade if/when things get sufficiently less hectic.

from leptonica.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.