Comments (7)
sprakash57
commented on June 11, 2024
1
Actually, chrome was not updated on my phone. I have updated it and now I am able to replicate the issue. i will keep you posted.
from neu_ui.
sprakash57
commented on June 11, 2024
I would like to work on this issue.
from neu_ui.
daniel-norris
commented on June 11, 2024
Sure, thanks for offering to contribute @sprakash57. You're now assigned.
from neu_ui.
sprakash57
commented on June 11, 2024
@daniel-norris need some help. Does the below change look good? Let me know if it fulfills the requirement.
Before changes, it was looking like this on mobile -
One more thing I have noticed that the Radio component rendered twice in the story. Do you want me to fix that as well?
from neu_ui.
daniel-norris
commented on June 11, 2024
Hey @sprakash57 this is what I'm getting currently on production on Android..
I wonder if this may be something to do with Storybook 🤔.
There is some alignment problems visible on desktop and Chrome v. 86.0.x but you cant replicate the exactly the same problem.
Are you able to replicate the problem on a mobile?
from neu_ui.
sprakash57
commented on June 11, 2024
@daniel-norris I have fixed the issue. Here is what I have done.
- Detected userAgent (Whether it's mobile or desktop browser)
- Applied CSS into styled-components as per userAgent.
Total lines of codes modified/added - 3
Final results -
- Mobile
- Desktop
from neu_ui.
sprakash57
commented on June 11, 2024
Raised #47 for review.
from neu_ui.
Related Issues (20)
- Create simple CardBody test HOT 2
- Create simple Card test
- Create a CardTitle test HOT 2
- Create simple CardSubtitle test HOT 2
- Create a CardText test HOT 2
- Create a CardImg test HOT 2
- Create a simple Radio component test
- Create a simple Form component test HOT 2
- Create a simple FormGroup component test HOT 2
- Create a simple Label component test
- Create a simple Select component test
- Create a simple Slider component test
- Create a simple TextArea component HOT 1
- Create a simple Toggle component test HOT 4
- Create a Progress component test HOT 3
- Improve Typography component test to 100% coverage HOT 2
- Button change cursor onhover HOT 2
- Create a simple ListGroup test HOT 1
- Create a simple ListItem test HOT 1
- Move CI pipeline from CircleCI to GitHub Actions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neu_ui.