Comments (5)
It is already possible to use odinfmt
with LSP command.
https://github.com/DanielGavin/ols/blob/master/src/server/format.odin
from ols.
It doesn't show up in sublime text, something must be missing, i'll investigate
from ols.
After investigation, i now understand the issue
I don't use ols.json
, i don't like having ton of files in my project's root folder, instead i setup ols via editor
The problem is:
- if ols doesn't find the
ols.json
file, then it'll usecommon.Config
with its default value (false), and send that to the client as the server capabilities- this is imo wrong as it incorrectly tell the client what the server really capable of
- when ols receive the config from the editor
workspace/didChangeConfiguration
, then it'll parse the setting, but it will never update the capabilities back to the client - therefore the client (Sublime Text), doesn't know that ols supports format/hover/inlay etc
I therefore suggest either:
- if no
ols.json
is not found, set the default values totrue
(i think that's the way to go) - have ols configurable on startup via program params
--enable-hover --enable-format
- when
workspace/didChangeConfiguration
is received, send back new server capabilities (i don't know if that's possible)
from ols.
Doesn't sublime send the config before workspace/didChangeConfiguration
with
interface InitializeParams extends WorkDoneProgressParams {
/**
* User provided initialization options.
*/
initializationOptions?: LSPAny;
on initialize?
Line 629 in 2dbdd75
from ols.
Looks like enable_format
wasn't supported in ols config, i sent a PR, check the linked one above this comment
from ols.
Related Issues (20)
- Parse statements with `or_continue` and `or_break` HOT 3
- Didn't compile HOT 1
- Items involving generic functions fail to return results depending on package scope. HOT 4
- Unable to find x library. HOT 1
- Constant timeouts HOT 9
- [odinfmt] Struct formatting is broken when there are many `where` cases HOT 1
- OLS timesout on format HOT 1
- New directive #hash isn't properly parsed by OLS HOT 1
- Stroustrup brace style inserting extra space in front of else HOT 1
- formatter only allows two values in for loop HOT 1
- OLS Build Failed HOT 1
- `foreign import` library path corrupted after code format HOT 3
- Build failure on Windows HOT 2
- Unhandled specialization `&Pointer_Type` HOT 2
- Crash on shadowing proc name in it's body HOT 6
- Comp literal disables completion when not using them as key value assignments
- OLS confused by bit field definitions HOT 1
- Failed to download nightly release HOT 1
- [enhancement] private struct variables HOT 3
- Put shorter variable attributes on one line with the attribute target HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ols.