Giter VIP home page Giter VIP logo

Comments (5)

DanielGavin avatar DanielGavin commented on July 20, 2024

It is already possible to use odinfmt with LSP command.

https://github.com/DanielGavin/ols/blob/master/src/server/format.odin

from ols.

ryuukk avatar ryuukk commented on July 20, 2024

It doesn't show up in sublime text, something must be missing, i'll investigate

from ols.

ryuukk avatar ryuukk commented on July 20, 2024

After investigation, i now understand the issue

I don't use ols.json, i don't like having ton of files in my project's root folder, instead i setup ols via editor

The problem is:

  • if ols doesn't find the ols.json file, then it'll use common.Config with its default value (false), and send that to the client as the server capabilities
    • this is imo wrong as it incorrectly tell the client what the server really capable of
  • when ols receive the config from the editor workspace/didChangeConfiguration, then it'll parse the setting, but it will never update the capabilities back to the client
  • therefore the client (Sublime Text), doesn't know that ols supports format/hover/inlay etc

I therefore suggest either:

  • if nools.json is not found, set the default values to true (i think that's the way to go)
  • have ols configurable on startup via program params --enable-hover --enable-format
  • when workspace/didChangeConfiguration is received, send back new server capabilities (i don't know if that's possible)

from ols.

DanielGavin avatar DanielGavin commented on July 20, 2024

Doesn't sublime send the config before workspace/didChangeConfiguration with

interface InitializeParams extends WorkDoneProgressParams {
/**
* User provided initialization options.
*/
initializationOptions?: LSPAny;

on initialize?

read_ols_initialize_options(

from ols.

ryuukk avatar ryuukk commented on July 20, 2024

Looks like enable_format wasn't supported in ols config, i sent a PR, check the linked one above this comment

from ols.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.