How do I notify when a workflow instance is completed? about workflow-core HOT 6 CLOSED

Why don't you make a last step in the builder that send the notification?

.Then<SendNotification>();

from workflow-core.

Currently there is no event like that, if you would like to submit a PR with this feature, I would be happy to merge it in.

from workflow-core.

In fact, I feel events shall be handy since the client only has a reference to the host. Maybe events can be added for step starts, step completes, workflow starts, workflow completes, or resume as well. I've tried to raise the workflow event (event defined in IWorkflowHost) from WorkflowExecutor. Not sure that is the best place.

To response to germandb, I think there is some difficulty to create a SendNotification step. I would expect the step shall consume a notification service, which can be injected in when the SendNotification step is created. However, the WorkflowStep is not created through dependency injection i.e. BodyType.GetConstructor(new Type[] { }), it is hard to access the notification service (except through some static singleton, which is not preferred) So it will be best if the step can be created through a dependency injector (or a factory backed by a dependency injector)

This is basically another issue.

from workflow-core.

If you register your steps with the ServiceCollection when building up your dependency injection container, then they will be created from the IoC container, failing that, it falls back to a parameterless constructor... see the following sample

https://github.com/danielgerlag/workflow-core/tree/master/src/samples/WorkflowCore.Sample15

from workflow-core.

Hi ewyuen when I say use a step I was thinking in something like danielgerlag say, I would implemented a step that call a interface that send the notifications.

from workflow-core.

Thank you germandb. and Daniel. In fact, I am able to inject a notification interface to my final step.

But I can see having a completion event is convenient. I will try to modify the codes and create a PR if good enough.

from workflow-core.