How to implement a cancellable waitfor about workflow-core HOT 7 CLOSED

Hi Marc,

We don't have that functionality (yet), for now would it make sense to implement a single WaitFor and branch the workflow based on the data passed to that WaitFor?
Looking forward, I will definitely keep this scenario in mind for a future release.

from workflow-core.

Hi Daniel

Thanks for your reply. If this is the only option right know, we have to think about that. The logic is a little bit more complex then described above and we'll end up with a loop and multiple if statements.

I played around with your cancellable task, but without any success. Does the waitfor fully block the execution internally? Would a waitany task for a parallel fork be an easier solution?

Another short question: Is there any way to check if a published event was handled?

Thanks,
Marc

from workflow-core.

Hi Marc,

So the CancellableStep class is used internally, currently only by the .Recur fluent builder over here:

https://github.com/danielgerlag/workflow-core/blob/master/src/WorkflowCore/Services/FluentBuilders/StepBuilder.cs#L360

I don't see why we couldn't overload the .WaitFor methods to also use this wrapper, over here:

https://github.com/danielgerlag/workflow-core/blob/master/src/WorkflowCore/Services/FluentBuilders/StepBuilder.cs#L114

If we had to implement the cancellation functionality as per it's use on the Recur step, would that solve your problem?

from workflow-core.

Hi Daniel

Yes, that would really help if we could wrap the WaitFor in a CancellableStep. I tried exactly this with an extension method. Did I understood it correctly that I can provide an expression which is evaluated over and over and if true then the contained step is cancelled?

Could you show me how I correctly wrap it? I think I did it wrong.

Best,
Marc

from workflow-core.

Hi Marc,

I have just published version 1.3.3 to NuGet, which adds a parameter to the WaitFor methods, allowing you to specify a cancel condition. See usage in the test here: https://github.com/danielgerlag/workflow-core/blob/master/test/WorkflowCore.IntegrationTests/Scenarios/CancelledEventScenario.cs

Let me know if this solves your problem

from workflow-core.

Hi Daniel

Thanks for your support! We did a quick test last week and it looked good so far. This week, we will integrate it into the big solution and I'll give you the more detailed feedback when we finish the integration.

Thanks
Marc

from workflow-core.

Glad to help, let me know if you run into any other issues

from workflow-core.