Comments (9)
Hey David,
sorry about that and thanks a lot for point it out.. would you mind
proposing a solution and submitting a pull request for it?
cheers,
d
On 23 August 2016 at 14:03, David R. Pugh [email protected] wrote:
@danielhomola https://github.com/danielhomola
In Python 3 it is not possible to compare an integer with a string as you
are doing here
https://github.com/danielhomola/mifs/blob/master/mifs.py#L222. The
result of this line will be a TypeError.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFJk-8LLWO4fDaOPug1pJRo5egMGlobsks5qiu-QgaJpZM4Jq5f3
.
Daniel Homola
from mifs.
I was emailed out of the blue by a user who wanted to know why the code didn't work on Python 3 and who wasn't able to raise an issue on GitHub directly (for whatever reason).
When I have some spare time I will try to submit a PR.
from mifs.
by a user?
On 24 August 2016 at 11:44, David R. Pugh [email protected] wrote:
@danielhomola https://github.com/danielhomola
I was emailed out of the blue by a user who wanted to know why the code
didn't work on Python 3 and who wasn't able to raise an issue on GitHub
directly (for whatever reason).When I have some spare time I will try to submit a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFJk-4vVPNu3Z5MpsV4s5KzHITsoLIacks5qjCB7gaJpZM4Jq5f3
.
Daniel Homola
from mifs.
Yes, apparently you have some! Congrats.
from mifs.
My sarcasm-meter exploded :D anyway thanks a lot for pointing it out!
On 24 August 2016 at 13:50, David R. Pugh [email protected] wrote:
@danielhomola https://github.com/danielhomola
Yes, apparently you have some! Congrats.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFJk--pPqo6ubcd_NS7TM1enRllWRUwrks5qjD4KgaJpZM4Jq5f3
.
Daniel Homola
from mifs.
I am currently using it with Python 3, it turned out to be a problem with how the print statements changed and how xrange is no longer supported. I can submit a PR in a bit, though I will test it with Python 2 as well before submitting.
from mifs.
@xangma This issues would seem to be additional to the one that I reported.
from mifs.
@davidrpugh Fair enough, I did come up against the one you reported too, I just forget what caused it. Regardless, it's fixed for me (subject to consistency testing) ...
from mifs.
@davidrpugh Sorry, I see what you're getting at now. It's a problem with how Python 3 now performs comparisons (or rather, doesn't). Fixed
from mifs.
Related Issues (20)
- ValueError: Expected 2D array, got 1D array instead HOT 1
- HELP!! All-NaN slice encountered HOT 13
- Python 3 Compatibility: print function missing parentheses HOT 1
- Python 3 Compatibility: xrange in mi.py HOT 1
- Bug: Issue in calculation of MI of unselected features with the previously selected feature in S HOT 3
- Question about using `knn.radius_neighbors` HOT 1
- unable to install HOT 1
- ValueError: numpy.nanargmax raises on a.size==0 and axis=None; So Bottleneck too. HOT 2
- AttributeError: 'module' object has no attribute 'MutualInformationFeatureSelector' HOT 1
- AttributeError: 'MutualInformationFeatureSelector' object has no attribute 'support_' HOT 1
- Negative Entropy Values and More
- Information changes (increases/decreases) upon adding duplicate features
- blog post link is not working HOT 3
- import fails using scikit-learn v 0.23.2
- IndexError: index 10 is out of bounds for axis 0 with size 10
- AttributeError: module 'mifs' has no attribute 'MutualInformationFeatureSelector'
- transform function for feature selector
- Error when importing SelectorMixin HOT 1
- sklearn.feature_selection.base is now sklearn.feature_selection._base
- Problem in threadpoolctl: "NoneType object has no attribute split" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mifs.