Giter VIP home page Giter VIP logo

Comments (6)

danielpalme avatar danielpalme commented on June 9, 2024 1

You are right.
I fixed that in fc1de1c.

The next release will contain the change. I plan the next release for November, once .NET8 is available.

from reportgenerator.

danielpalme avatar danielpalme commented on June 9, 2024 1

What about Case 2? When a single line is both covered and not covered, it should be considered partially covered (since ReportGenerator doesn't support coverage mapping by lines and columns). I don't see that in a commit, but maybe I'm wrong :)

No, you are not wrong. In your example line 31 would be considered as covered.
I will see, if I can find a good solution for that case.
It might easily become complex, if line elements are overlapping (I don't know if that can happen in practice).

from reportgenerator.

danielpalme avatar danielpalme commented on June 9, 2024 1

Just made the necessary changes in 8278973.
I will let you know once the next release is available.

from reportgenerator.

RoadTrain avatar RoadTrain commented on June 9, 2024

What about Case 2? When a single line is both covered and not covered, it should be considered partially covered (since ReportGenerator doesn't support coverage mapping by lines and columns).
I don't see that in a commit, but maybe I'm wrong :)

from reportgenerator.

RoadTrain avatar RoadTrain commented on June 9, 2024

What about Case 2? When a single line is both covered and not covered, it should be considered partially covered (since ReportGenerator doesn't support coverage mapping by lines and columns). I don't see that in a commit, but maybe I'm wrong :)

No, you are not wrong. In your example line 31 would be considered as covered. I will see, if I can find a good solution for that case. It might easily become complex, if line elements are overlapping (I don't know if that can happen in practice).

Thanks. With the assumption that the line elements for a particular method cannot overlap it seems doable with something like a two-dimensional array LineVisitStatus[][] where each line is mapped to all statuses within that line.

If needed, we can test it on our fairly large report to see if anything goes wrong.

from reportgenerator.

danielpalme avatar danielpalme commented on June 9, 2024

Release 5.2.0 is now available.

from reportgenerator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.