Giter VIP home page Giter VIP logo

Comments (5)

DarioBalinzo avatar DarioBalinzo commented on July 4, 2024

Hey @konstan,
Yes, it is intentional. I'm converting the names in order to be compatible with the Avro serialization (see here: https://avro.apache.org/docs/1.8.1/spec.html#names).

Is this a blocking problem for you?
Actually, I might enable a config to turn on/off this name conversion if you think this might be useful (the conversion logic is isolated in a single Java class ).

from kafka-connect-elasticsearch-source.

konstan avatar konstan commented on July 4, 2024

Hi @DarioBalinzo ,

Yes, our code generates loads of attributes with dashes. It would be simpler for the processing downstream if the attributes wouldn't change. If it's possible, a configuration parameter would be highly appreciated.
Thank you!

from kafka-connect-elasticsearch-source.

DarioBalinzo avatar DarioBalinzo commented on July 4, 2024

Hi @feed3r, would you like to help me in developing this issue?

Please make AvroName class non static, and create a new interface for its public methods (calling the new interface something like FieldNameConverter).
Then you can create also a NopNameConversion class (that implements FieldNameConverter) that is not changing the original name.

Finally in the ElasticSourceTask class initialize both SchemaConverter and StructConverter, passing in the constructor an instance of AvroName
or NopNameConversion depending on the user configuration.

For testing, please refer to SchemaConverterTest and ElasticSourceTaskTest files.

from kafka-connect-elasticsearch-source.

DarioBalinzo avatar DarioBalinzo commented on July 4, 2024

Hi @konstan,
we just released version 1.2 with the new config.

You can find the description of the new param in the readme (fieldname_converter).

from kafka-connect-elasticsearch-source.

konstan avatar konstan commented on July 4, 2024

@DarioBalinzo I validated the feature and it works correctly in my case. Thanks a lot!

from kafka-connect-elasticsearch-source.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.