Giter VIP home page Giter VIP logo

Comments (11)

ChihChengYang avatar ChihChengYang commented on May 26, 2024 1

No, that got the same fail even pruning build dir or retrying.

Following make steps: (Ubuntu 16.04 32 or 64bit , gcc 5.4.0 )

  1. git clone https://github.com/LebedevRI/rawspeed
  2. checkout 4ccee4a
  3. mkdir build; cd build;
  4. cmake .. -DALLOW_DOWNLOADING_PUGIXML=ON -DUSE_BUNDLED_PUGIXML=ON -DALLOW_DOWNLOADING_GOOGLETEST=ON
  5. make
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp: In member function ‘virtual void rawspeed_test::MakeUniqueTest_Test_Test::TestBody()’:
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp:285:14: error: ‘make_unique’ is not a member of ‘std’
     auto s = std::make_unique<int>(0);
              ^
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp:285:31: error: expected primary-expression before ‘int’
     auto s = std::make_unique<int>(0);
                               ^
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp:286:5: error: template argument 1 is invalid
     ASSERT_EQ(*s, 0);
     ^
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp:289:14: error: ‘make_unique’ is not a member of ‘std’
     auto s = std::make_unique<int>(314);
              ^
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp:289:31: error: expected primary-expression before ‘int’
     auto s = std::make_unique<int>(314);
                               ^
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp:290:5: error: template argument 1 is invalid
     ASSERT_EQ(*s, 314);
     ^
At global scope:
cc1plus: error: unrecognized command line option ‘-Wno-used-but-marked-unused’ [-Werror]
cc1plus: error: unrecognized command line option ‘-Wno-missing-variable-declarations’ [-Werror]

from rawspeed.

ChihChengYang avatar ChihChengYang commented on May 26, 2024 1

@LebedevRI The building error has been fixed. Thank you. :)

from rawspeed.

LebedevRI avatar LebedevRI commented on May 26, 2024

Hi.
Please duplicate this issue into your's distribution's bugtracker: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871250
And pass me the bug number.
After i have a few bugid's, i'll add a temporary workaround.

from rawspeed.

LebedevRI avatar LebedevRI commented on May 26, 2024

So far this is as far as i was able to go:
(#gcc on freenode)

[14:28:27] <LebedevRI> hello. is there a gcc bug# for this issue already https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871250 ? i can only find https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78019 but that is different
[15:15:17] <redi> LebedevRI: I don't recall seeing one.
[15:15:26] <redi> " I'm unable to report this upstream, since registration is closed, and password recovery does not seem to function."
[15:15:26] <LebedevRI> now you do :/
...
[15:21:27] <redi> LebedevRI: anyway, if it's a bug in gcc5 and is fixed in gcc6 then there's no point in an upstream bug report
[15:21:35] <redi> it would probably be closed as FIXED
[15:22:19] <LebedevRI> great. can i quote you on that?
[15:22:49] <redi> sure
[15:23:10] <LebedevRI> problem being, i can't just go and bump compiler requirement up to 6
[15:24:03] <LebedevRI> so the fact that gcc5 is the only one with this issue does not help

I'm rather tempted to close this as WONTFIX.

from rawspeed.

ChihChengYang avatar ChihChengYang commented on May 26, 2024

Hi,
Ok, got it. Thank you for your information.

from rawspeed.

LebedevRI avatar LebedevRI commented on May 26, 2024

from rawspeed.

ChihChengYang avatar ChihChengYang commented on May 26, 2024

I build this branch https://github.com/LebedevRI/rawspeed can pass the prior error with gcc 5.4.0 but getting another error as below. gcc-7 , clang++-3.9, 4.0 get the fail as well. :(

[ 43%] Building CXX object src/librawspeed/test/CMakeFiles/CommonTest.dir/__/common/CommonTest.cpp.o
In file included from /home/jeff/rawspeed/build/googletest/googletest-src/googletest/include/gtest/gtest.h:58:0,
                 from /home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp:25:
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp: In member function ‘virtual void rawspeed_test::MakeUniqueTest_Test_Test::TestBody()’:
/home/jeff/rawspeed/src/librawspeed/common/CommonTest.cpp:285:14: error: ‘make_unique’ is not a member of ‘std’
     auto s = std::make_unique<int>(0);
              ^

from rawspeed.

LebedevRI avatar LebedevRI commented on May 26, 2024
  1. that commit is in this repo, 4ccee4a
  2. building works: for gcc-7, clang-4.0: https://travis-ci.org/darktable-org/rawspeed/builds/262338230
    so the problem is local to you. maybe you forgot to prune build dir.

from rawspeed.

LebedevRI avatar LebedevRI commented on May 26, 2024

@ChihChengYang were you able to resolve your build issue?

from rawspeed.

LebedevRI avatar LebedevRI commented on May 26, 2024

Finally, reproduction steps :)
Ok, something is wrong when -DUSE_BUNDLED_PUGIXML=ON is specified together with -DBUILD_TESTING=ON

from rawspeed.

LebedevRI avatar LebedevRI commented on May 26, 2024

@ChihChengYang please try building git develop branch of this repo.

from rawspeed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.